Hacktoberfest 2026: những issue maintainer đã đánh dấu cho tháng Mười, đang mở và phù hợp người mới. Xem issue Hacktoberfest

[workshop-update] Fix workshop destroy-lifecycle content drift and close glossary gaps

Đã đóng
  • Có gì không ổn?
#392 0 bình luận 0 reaction 0 người được giao Xem trên GitHub

Maintainer thường phản hồi trong vòng 2 ngày

Chưa có ai nhận issue này.

Đánh giá

Độ khó
1/5
Thời gian dự kiến
Dưới một giờ
Mức phù hợp với người mới
1/100
Loại issue
Tài liệu
Độ rõ ràng
Đặc tả rõ ràng
Mức độ hoạt động
Sôi nổi
Công nghệ
azure, markdown
Lĩnh vực
documentation

Hướng nghiên cứu

The body says the changes are already pushed to workshop-coverage-update-20261005-d65574bb617a1c57 and provides a link to create the pull request. The listed workshop files and preview describe completed edits; this issue is not unclaimed first-contributor work to pick up.

Do mô hình lập chỉ mục viết ra từ nội dung của issue.

Mô tả

agentic-workflows workshop workshop-sync

[!TIP]
Your pull request is ready to create! 🎉 ✅

Everything is OK—the changes have been pushed to branch workshop-coverage-update-20261005-d65574bb617a1c57. Please review the changes, including any protected files, before creating the pull request.

Create the pull request

The original pull request description is below.

Summary

Weekly workshop coverage pass. Found and fixed one real content-drift bug plus closed several glossary/naming gaps surfaced by the workshop inventory.

Changes, per feature

1. Track 3 Lab 6 ("Destroy Lifecycle") — internal contradiction, now fixed
workshops/track-3-platform-engineering/lab-06-destroy-lifecycle.md

The lab described the old per-resource-group destroy flow in Steps 1–5 (read RG name → inventory → delete subscription-scoped resources → delete RG), while Steps 6–8 — appended in a later pass — correctly describe the current Azure Deployment Stack flow (az stack sub delete --action-on-unmanage deleteAll). These two descriptions directly contradicted each other. Rewrote Step 4 to describe the stack-based flow consistently, and tightened Steps 6–8 to remove duplication.

  • Persona/track: DevOps/SRE / Track 3 — this is exactly the audience that runs the CI destroy workflow and needs an accurate mental model of what it does.

2. az group delete anti-pattern in cleanup sections — now fixed
workshops/track-2-deploy-like-a-pro/lab-05-drift-detection.md, workshops/track-3-platform-engineering/lab-06-destroy-lifecycle.md

Both labs told attendees to clean up leftover deployments with a raw az group delete. The azure-stack-destroy SKILL.md explicitly flags this as wrong for Git-Ape-managed deployments — it skips the soft-delete purge sweep (Key Vault, Cognitive Services linger 7–90 days) and misses subscription-scope resources (role/policy assignments) a stack can own. Replaced both call sites with /azure-stack-destroy, the same primitive the CI destroy workflow uses, and limited az group delete to resource groups created outside Git-Ape.

  • Persona/track: Engineer / Track 2 and DevOps / Track 3 — both tracks deploy real resources and need a cleanup step that doesn't contradict the product's own documented guardrail.

3. azure-stack-deploy / azure-stack-destroy skills — glossary gap closed
workshops/shared/glossary.md

Both skills had 0 refs in workshops/ per the coverage inventory. The behaviour is already lab-covered through @git-ape's deploy/destroy flow and the fix above, so rather than invent a new lab I added glossary entries mapping the CLI primitive attendees already see to the skill name that drives it.

  • Persona/track: Engineer / Track 2, DevOps / Track 3.

4. azure-requirements-gatherer agent — glossary gap closed
workshops/shared/glossary.md

0 refs by exact agent-slug match, but extensively covered under its display name "Requirements Gatherer" in Track 1/2 labs, demo scripts, and the Track 2 deck — a false-positive from the grep-proxy inventory, confirmed by reading the actual content. Added it to the glossary's agent table (the one agent missing there).

  • Persona/track: Beginner / Track 1, Engineer / Track 2.

5. azure-resource-availability skill — named explicitly
workshops/track-1-zero-to-deploy/lab-02-first-deploy.md

The behaviour (region/runtime/provider/CAF-name checks) was already described in Lab 2 Step 3, but the skill was never named. Naming-only fix, no content invented.

  • Persona/track: Beginner / Track 1.

6. azure-rest-api-reference skill — citation added
workshops/track-2-deploy-like-a-pro/lab-02-web-app-sql.md

0 refs. This is an internal correctness tool the Template Generator uses before writing ARM resources, not something attendees invoke directly in any lab today. Added a "Going further" citation rather than inventing a new lab section, since there's no attendee-facing behaviour to ground a dedicated lab in yet. Flagged in the coverage-status issue as optional future work (e.g., a callout in Lab 3's security-deep-dive error-recovery flow) for a human to decide on.

  • Persona/track: Engineer / Track 2 (tentative — see coverage issue for the ambiguity note).
Guardrails confirmed
  • ✅ No lab timing changed (Track 1 still 30 min total, Track 2 60 min, Track 3 90–130 min, Track 4 untouched).
  • ✅ No-Azure fallback paths untouched (didn't touch Track 1 Lab 2's review-only path).
  • ✅ No rendered binaries (*.pdf, *.pptx, *.html) touched — only .md lab/glossary files.
  • ✅ No deck source (*_deck.md) edited, so the L1/L11/L15 deck lint rules don't apply to this PR.
  • ✅ No files outside workshops/ touched.
  • ✅ Every described command/behaviour (az stack sub delete --action-on-unmanage deleteAll, the availability-check APIs, the glossary skill descriptions) is verified against the actual skill SKILL.md sources, not invented.
Links
  • Coverage-status issue: see the [workshop-coverage] issue opened alongside this PR for the full gap table and persona reasoning.
  • Resolves the workshop-content side of the drift flagged for the destroy lifecycle — no workshop-sync issue body was readable this run (integrity-policy redaction on #378/#379/#365/#351), so no Closes # reference is included; a human should confirm whether any of those map directly to the fixes above.

[!NOTE]
GitHub Actions is not permitted to create or approve pull requests in this repository.

The changes have been pushed to branch workshop-coverage-update-20261005-d65574bb617a1c57 and are ready to review.

To fix the permissions issue, go to Settings → Actions → General and enable Allow GitHub Actions to create and approve pull requests. See also: gh-aw FAQ

Show patch preview (38 of 197 lines) 
From 045c8338760c9320ab74bdfde745bce0f131b7d1 Mon Sep 17 00:00:00 2001
X-GH-AW-Base-Commit: 01daa4bc716ea1a1e1a4886cb9d1dc60c5c3d56a
From: "github-actions[bot]" <github-actions[bot]@users.noreply.github.com>
Date: Mon, 5 Oct 2026 21:47:54 +0000
Subject: [PATCH] workshop: fix stale az group delete destroy guidance, close
 azure-stack-deploy/destroy coverage gap

- Track 3 Lab 6 and Track 2 Lab 5 described/recommended raw 'az group delete'
  for teardown, which contradicts the azure-stack-destroy skill's explicit
  guardrail (misses soft-delete purge and subscription-scope resources).
  Replaced with the /azure-stack-destroy skill, matching the same
  az stack sub delete --action-on-unmanage deleteAll primitive the CI
  destroy workflow uses.
- Track 3 Lab 6 Steps 1-5 described the old per-resource-group destroy flow
  while Steps 6-8 (appended later) described the stack-based flow -
  resolved the contradiction so the lab consistently teaches the current
  Deployment Stack based destroy lifecycle.
- Added azure-stack-deploy and azure-stack-destroy skills, and the
  Requirements Gatherer agent, to workshops/shared/glossary.md (0 refs
  previously, per workshop inventory).
- Cited azure-resource-availability explicitly in Track 1 Lab 2 Step 3
  (the step already describes its behaviour but never named the skill)
  and azure-rest-api-reference in Track 2 Lab 2 Going Further.

Co-authored-by: Copilot <[email protected]>
---
 workshops/shared/glossary.md                  |  5 ++
 .../lab-02-first-deploy.md                    |  6 +--
 .../lab-02-web-app-sql.md                     |  1 +
 .../lab-05-drift-detection.md                 |  8 +--
 .../lab-06-destroy-lifecycle.md               | 50 +++++++------------
 5 files changed, 33 insertions(+), 37 deletions(-)

diff --git a/workshops/shared/glossary.md b/workshops/shared/glossary.md
index 48cf741..303df59 100644
--- a/workshops/shared/glossary.md
+++ b/workshops/shared/glossary.md
@@ -28,6 +28,
... (truncated)

Generated by Workshop Content Auto-Updater · copilot · auto · 118.5 AIC · ⌖ 9.05 AIC · ⊞ 12K · ◷

Ngôn ngữ chính
JavaScript
Star
273
Fork
49
Merge trung bình
2 ngày 12 giờ
Pull request đã merge (30 ngày)
28

Chuẩn bị môi trường

Mở trong Codespaces

Khởi chạy dev container của dự án ngay trên trình duyệt, bằng tài khoản GitHub của bạn.

Bắt đầu từ đâu

  1. Đọc hết issue, rồi đọc hướng dẫn đóng góp của dự án.
  2. Bình luận trên issue rằng bạn sẽ nhận — tránh hai người làm cùng một việc.
  3. Fork repository và làm thay đổi trên một nhánh.
  4. Mở pull request có tham chiếu số hiệu của issue.

Issue khác của Azure/git-ape

Tất cả issue của Azure/git-ape

Issue tương tự

Thêm issue về JavaScript

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.