Add a way to enable/disable echo in TermImpl echoHandler
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 48/100
Research direction
Start in TermImpl.java and inspect the echoHandler in its constructor. Add a way to toggle echoing without replacing the handler, while preserving readline event queuing. Done means input echo can be enabled or disabled for cases such as password entry.
Written by the indexing model from the issue text.
Description
Read me
Read this first before creating an issue:
- do not use this issue tracker to ask questions, instead use one of these channels. Questions will likely be closed without notice.
- you shall create a feature request only when it is general purpose enough.
- make sure that the feature is not already
Describe the feature
Allow enable/disable echoing input characters back to the remote client.
Use cases
This allows temporarily disabling echo, for example to input a password, without replacing echoHandler and losing built-in readline functionality.
Contribution
Proposed implementation in TermImpl.java:
- Add a new class field:
private boolean echoOn = true;
- Add an if block in the constructor:
echoHandler = codePoints -> {
// Echo
if (echoOn) {
echo(codePoints);
}
readline.queueEvent(codePoints);
};
- Add a setter:
public void setEchoOn(boolean echoOn) {
this.echoOn = echoOn;
}
- Dominant language
- Java
- Stars
- 39
- Forks
- 19
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from vert-x3/vertx-shell
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
vert-x3/vertx-shell#39 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
vert-x3/vertx-shell#38 ·
-
Difficulty 5/5 Over a week Newbie friendliness 20/100
vert-x3/vertx-shell#37 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
vert-x3/vertx-shell#33 · 5 comments ·
-
http client commandOpen
Difficulty 5/5 Over a week Newbie friendliness 25/100
vert-x3/vertx-shell#24 · 2 comments ·
All issues in vert-x3/vertx-shell
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 75/100
521xueweihan/HelloGitHub#4105 ·
-
Awaiting further input from submitter
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
code-maintenance
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
Maintainers usually reply within 1 day