dos2unix
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- shell
- Domain
- build-system
Research direction
Start with pack.sh, especially line 23 and the dos2unix -q ./$workdir/hook.sh invocation, then inspect hook.sh's line endings and run the packaging command shown in the issue. Determine whether the missing command affects generated files or only normalization, and make the script's behavior clear when dos2unix is unavailable or unnecessary.
Written by the indexing model from the issue text.
Description
Can i safely ignore this if all injected files were created on linux and should already have proper line endings?
or is it used by files in the archive, or script?
~/bin/ventoy-1.1.10-linux/live-injection-1.0
$./pack.sh
packing sysroot ...
./pack.sh: 23: dos2unix: not found
packing live_injection ...
-e
========== SUCCESS ============
thanks,
RS
EDIT
I looked in the script and only found it on one line;
dos2unix -q ./$workdir/hook.sh
i opened the hook.sh file, and it seems it already has UNIX(LF) line endings.
so I am guessing my original assumption should be correct? 🤔
If so you can close this.
Maybe you could edit the script to add a message or something?
or just skip that line if already on Linux? 🤔
Without knowing your original intentions its hard to give suggestions.
Thanks for making an otherwise awesome program!
- Dominant language
- Shell
- Stars
- 44
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Similar issues
-
0. to triage
Difficulty 1/5 Under an hour Newbie friendliness 80/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
EchoTools/nevr-runtime#171 · 1 comment ·
Maintainers usually reply within 1 day
-
Shell installer: updating PATH replaces symlinked profiles and changes existing file permissionsOpenbug CLI
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
area/testing kind/cleanup priority/backlog triage/accepted
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
lexfrei/cloudflare-tunnel-gateway-controller#999 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day