Route VCL P3: ghost sets X-Ghost-VCL-Slot for the matched route
Maintainers usually reply within 5 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 68/100
Research direction
Start with the Route type and ghost VMOD configuration in internal/ghost, then find where matched routes set X-Gateway-Route and X-Gateway-Listener and where the preamble strips internal headers. Add the slot header for routes with a slot and ensure it is absent otherwise. Write a VTC covering both cases; backend filtering is optional and depends on the capacity spike.
Written by the indexing model from the issue text.
Description
Part of #94. Depends on the ghost instance-state work in #93, which has landed.
Ghost decides which route a request matched, so ghost is what tells the master VCL which slot to jump to.
Work
- Add
vcl_slotto theRoutetype ininternal/ghostand to the ghost VMOD's config. - Set
X-Ghost-VCL-Sloton the request when the matched route has a slot, alongside the existingX-Gateway-RouteandX-Gateway-Listener. - Strip
X-Ghost-VCL-Slotin the preamble's trust-boundary block, like the other internal headers. - Optional, depending on the capacity spike: a constructor argument so a route VCL's ghost instance builds only the backends its own routes need, instead of a full copy of the backend set.
Done when
A VTC shows the header set for a route that has a slot, and absent for one that does not.
Notes
Size S.
- Dominant language
- Go
- Stars
- 16
- Forks
- 3
- Avg merge
- 5d 15h
- Merged PRs (30d)
- 10
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from varnish/gateway
-
Difficulty 2/5 1-3 hours Newbie friendliness 83/100
Maintainers usually reply within 5 days
-
beta documentation
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
varnish/gateway#58 · 1 comment ·
Maintainers usually reply within 5 days
-
beta documentation
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
varnish/gateway#52 · 1 comment ·
Maintainers usually reply within 5 days
-
beta enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 5 days
-
Difficulty 5/5 Over a week Newbie friendliness 12/100
varnish/gateway#123 · 1 comment ·
Maintainers usually reply within 5 days
Similar issues
-
enhancement exporter/awskinesis needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
open-telemetry/opentelemetry-collector-contrib#53334 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
erigontech/erigon#26523 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 83/100
SocialGouv/iterion#3376 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
seaweedfs/seaweedfs#12740 · 2 comments ·
Maintainers usually reply within 1 day
-
area:indexer bug needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
seanb4t/codegraph-go#385 ·
Maintainers usually reply within 1 day