INFO is answered by a single shard, so cluster-wide sections are incomplete
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Start with the INFO forwarding path at src/fanout.c:3509 and compare it with the broadcast and aggregation path used by DBSIZE; check src/cmd.c and COMMANDS.md for the command's current status. Decide which INFO sections can be combined across masters and how the proxy should report its cluster mode; done means INFO presents consistent cluster-wide data and matches the proxy's standalone behavior.
Written by the indexing model from the issue text.
Description
Summary
INFO is forwarded to the first master only (src/fanout.c:3509, the single-node forward path), and that node's reply is returned as-is. Sections that describe data or load across the cluster therefore cover only one shard.
Observed behavior
Tested on a local 3-master cluster (Valkey 8.1), commit b8a9990. The same proxy, same moment:
INFO keyspace -> db0:keys=11,expires=0,avg_ttl=0
DBSIZE -> 26
DBSIZE is broadcast and summed, so the two disagree.
Other sections come from that one backend node too. INFO cluster reports cluster_enabled:1 even though the proxy presents itself as a standalone server and rejects CLUSTER commands. A client or monitoring tool that checks this field will switch to cluster mode and fail.
Steps to reproduce
- Start the proxy against a cluster with more than one master and keys spread across slots.
- Through the proxy, compare
INFO keyspacewithDBSIZE. - Through the proxy, run
INFO cluster.
Expected behavior
Some options, which may overlap with the planned INFO work:
- Aggregate the sections where a sum makes sense (keyspace, the counters in stats, commandstats) across all masters.
- Report
cluster_enabled:0, or leave the field out, since clients talk to the proxy as a standalone server. - A proxy-specific section (connections, pools, routing) could live alongside these. Happy to help with that part.
Minor: COMMANDS.md lists INFO as "Planned", while src/cmd.c already has it on the supported command list.
- Dominant language
- C
- Stars
- 18
- Forks
- 6
- Avg merge
- 18h 44m
- Merged PRs (30d)
- 27
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from valkey-io/valkey-proxy
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
valkey-io/valkey-proxy#45 ·
Maintainers usually reply within 1 day
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
valkey-io/valkey-proxy#44 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
valkey-io/valkey-proxy#43 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 55/100
valkey-io/valkey-proxy#32 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 35/100
valkey-io/valkey-proxy#28 · 3 comments ·
Maintainers usually reply within 1 day
All issues in valkey-io/valkey-proxy
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
schrodinger/pymol-open-source#532 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
facebookexperimental/hermit#347 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 86/100
CTSRD-CHERI/cheribsd#2769 ·
Maintainers usually reply within 2 days
-
good first issue not started
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
CU-Robotics/firmware#257 ·
-
documentation good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100