Switch to opaque structs
Maintainers usually reply within 1 day
@michael-grunder is already working on this.
Since Jul 2, 2024.
Assessment
This issue has not been assessed yet.
Description
Right now, we declare valkeyContext, valkeyAsyncContext, valkeyClusterContext, and valkeyAsyncClusterContext in our public headers, exposing their memory layout.
This makes it a lot harder to make changes to them without breaking the ABI contract and therefore having to bump the SONAME.
We could switch to simply defining:
typedef struct valkeyContext valkeyContext;
typedef struct valkeyClusterContext valkeyClusterContext;
in our public headers, and declare the actual struct internally in a private header.
The only real downside is that it might break code for users who are directly accessing struct members. Personally, I can live with that 😄.
@bjosv @zuiderkwast What does everybody think?
- Dominant language
- C
- Stars
- 62
- Forks
- 26
- Avg merge
- 1d 5h
- Merged PRs (30d)
- 18
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from valkey-io/libvalkey
-
Alternative name for freeReplyObject.Possibly taken @bjosv claimed this 200 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 45/100
valkey-io/libvalkey#288 · 2 comments ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
valkey-io/libvalkey#208 · 2 comments ·
Maintainers usually reply within 1 day
-
Hide valkeyContextOpen
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Maintainers usually reply within 1 day
All issues in valkey-io/libvalkey
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Policy query leaks host primary block (BSL_PrimaryBlock_deinit skipped) on two early-exit pathsOpen
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
NASA-AMMOS/BSL#355 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
arancormonk/dsd-neo#660 ·
Maintainers usually reply within 1 day
-
[Bug]: remote-ls --updates reports up-to-date OCI refs because it ignores deployed Alt-idPossibly taken @Joao-kouznetz claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
#242 leftovers: dated narrative and shas in the social-features test planPossibly taken A pull request linked to this issue is open or already merged. Open
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
EchoTools/nevr-runtime#264 ·
Maintainers usually reply within 1 day