Language selection in sharing view broken
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- tailwindcss, typescript
- Domain
- frontend
Research direction
Start with packages/react-zen/src/components/Popover.tsx at the linked line and inspect how its w-72 sizing affects the sharing dialog. Check the language-selection view at desktop and mobile sizes; done means the columns fit on desktop and the menu remains usable on mobile.
Written by the indexing model from the issue text.
Description
When opening the dialog its trying to display multiple columns. But the box is limited it to w-72 in the code. Removing that classes on desktop fixes the issue but on mobile the menu needs some more love. See relevant line: https://github.com/umami-software/zen/blob/e984734f77dcd90c9eadbfc17e4865346f1f3f3f/packages/react-zen/src/components/Popover.tsx#L60
Its looks like this in umami version v3.5.0:
- Dominant language
- TypeScript
- Stars
- 59
- Forks
- 9
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from umami-software/zen
-
[Bug] Zen UI Select component does not display in DemoPossibly taken @Bhavysinghal claimed this 158 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 58/100
umami-software/zen#11 ·
-
Difficulty 1/5 1-3 hours Newbie friendliness 55/100
umami-software/zen#9 ·
All issues in umami-software/zen
Similar issues
-
Stop retrying permanent GitHub API failures in retry.shPossibly taken @muspi-merol-review claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
promplate/code-review#113 · 1 comment ·
Maintainers usually reply within 1 day
-
triage
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Maintainers usually reply within 1 day
-
サムネイルの Storage のバケット(`thumbnails`)に、大きさの上限(1 MiB)と許可する種類(JPEG、PNG、WebP)を設定するPossibly taken @ykzts claimed this today. Opentech: supabase
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
inabagumi/shinju-date#7147 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
elecnix/your-attention#129 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
umami-software/umami#4780 ·
Maintainers usually reply within 3 days