Language selection in sharing view broken

Open Beginner friendly
#13 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
tailwindcss, typescript
Domain
frontend

Research direction

Start with packages/react-zen/src/components/Popover.tsx at the linked line and inspect how its w-72 sizing affects the sharing dialog. Check the language-selection view at desktop and mobile sizes; done means the columns fit on desktop and the menu remains usable on mobile.

Written by the indexing model from the issue text.

Description

bug

When opening the dialog its trying to display multiple columns. But the box is limited it to w-72 in the code. Removing that classes on desktop fixes the issue but on mobile the menu needs some more love. See relevant line: https://github.com/umami-software/zen/blob/e984734f77dcd90c9eadbfc17e4865346f1f3f3f/packages/react-zen/src/components/Popover.tsx#L60

Its looks like this in umami version v3.5.0:
grafik

Dominant language
TypeScript
Stars
59
Forks
9
PR merge metrics
No merged PRs in 30d

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from umami-software/zen

All issues in umami-software/zen

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.