ucb-bar/onnxruntime-riscv

Refactoring: Use the inbuilt im2col NHWC?

Open

#26 opened on Jan 27, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (37 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (93 stars)
PR merge metrics
 (PR metrics pending)

Description

More of a code cleanliness thing, but currently for im2col in nhwc layout we use our own method that I took from the pytorch docs. ONNXRuntime also includes its own im2col nhwc implementation (see the cpu math ops). The two functions are basically identical except in our own im2col_nhwc function it does it for all groups whereas the ORT one only does it for one group. So when you refactor you'll have to move the im2col inside the for-loop where we iterate over the groups.

Contributor guide

Research direction
Examine the existing custom im2col nhwc function and the ORT built in im2col. Then refactor by moving the im2col call inside the for loop that iterates over groups, so that it operates on one group at a time.
Tech stack
cpp
Domain
backendapi
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++ONNXRuntime internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60