FB-004: max_cycles counts per period, docstring says per day [trap]
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 45/100
Research direction
Start with the engine docstring at engine.py:85 and the daily reset in strategy.py:416 to confirm how cycle counts work across periods. Then trace where max_cycles is enforced and how strategies set it; the issue notes 76 hard-coded uses across 67 files. Done means the docs describe the per-period behavior and an optional per-day budget is added.
Written by the indexing model from the issue text.
Description
Severity: trap · Source: BUGS_FASTBT.md (2026-10-09)
The engine docstring (engine.py:85) says "per day". current_cycle is reset only in _reset_for_new_day (strategy.py:416), which runs once per period. So max_cycles=1 means one trade per week or month, and a max_cycles == 1 guard in a strategy means something different in each mode.
Note: this repo's strategies carry 76 hard-coded max_cycles=1 across 67 files, turning re-entry strategies into single-entry ones.
Workaround: set max_cycles per period explicitly and enforce any per-day budget in strategy code.
Fix: document it as per-period, and add an optional per-day cycle budget.
- Dominant language
- Python
- Stars
- 28
- Forks
- 17
- Avg merge
- 8h 50m
- Merged PRs (30d)
- 2
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from uberdeveloper/fastbt
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 48/100
uberdeveloper/fastbt#31 ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 52/100
uberdeveloper/fastbt#30 ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 48/100
uberdeveloper/fastbt#28 ·
-
FB-008: close_trade mixes price and tick; stale exits are silent (zero-P&L fallback) [silent-wrong]Openbug
Difficulty 3/5 1-2 days Newbie friendliness 70/100
uberdeveloper/fastbt#27 ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 55/100
uberdeveloper/fastbt#26 ·
All issues in uberdeveloper/fastbt
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
omegaup/omegaup#10353 · 1 comment ·
Maintainers usually reply within 5 days
-
bot-triaged module: LrScheduler module: optimizer triaged
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
documentation glm5 llm-model
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
vllm-project/vllm-ascend#19062 ·
Maintainers usually reply within 1 day
-
author-page correction
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
acl-org/acl-anthology#10496 · 1 comment ·
Maintainers usually reply within 1 day