Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

FB-003: on_day_start / on_day_end fire once per PERIOD, not per day [trap]

Open
#22 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
38/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
backend

Research direction

Start by reading engine.py around lines 209 and 229, the on_day_start and on_day_end docstrings in strategy.py, and the “Proposed enhancements” section of BUGS_FASTBT.md. Trace how the hooks are called for each period and how ctx.is_new_date signals date changes during ticks. Done means the hooks run for every date in a period and returning False from on_day_start skips only that date.

Written by the indexing model from the issue text.

Description

bug

Severity: trap · Source: BUGS_FASTBT.md (2026-10-09)

engine.py:209 and engine.py:229 call them once per period, but their docstrings (strategy.py:431, :495) say "once per day". There is no per-date hook; the only per-date signal is polling ctx.is_new_date inside ticks. on_day_start returning False skips the whole period.

Impact: daily signal state (opening range, traded-today, daily counters) is built only on the period's first date.

Workaround: detect ctx.is_new_date in the tick hooks.
Fix: hook ladder — on_run_start → on_period_start → on_day_start/on_day_end (every date) → on_period_end → on_run_end (see BUGS_FASTBT.md "Proposed enhancements").

Dominant language
Python
Stars
28
Forks
17
Avg merge
8h 50m
Merged PRs (30d)
2

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from uberdeveloper/fastbt

All issues in uberdeveloper/fastbt

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.