Add test coverage for DuckDBVortexLoader
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 58/100
Research direction
Start with tests/backtest/test_data.py and the DuckDBVortexLoader implementation in src/fastbt/backtest/data.py; inspect the existing parquet fixture and DataSource protocol tests. Restore a fixture that converts the parquet fixture to vortex format, then parametrize the loader tests for both implementations. Check the project’s test dependency setup to decide how the vortex extension is provided, and run the data tests to confirm both loaders pass.
Written by the indexing model from the issue text.
Description
Summary
The DuckDBVortexLoader class in src/fastbt/backtest/data.py currently ships without test coverage. The vortex test fixtures were removed from tests/backtest/test_data.py during the v0.8.0 release cleanup.
TODO
- Add back a
vortex_pathfixture that converts the parquet test fixture to vortex format - Parametrize the
loaderfixture to run allDataSourceprotocol tests against bothDuckDBParquetLoaderandDuckDBVortexLoader - Consider whether vortex extension should be a test dependency or optional
Context
The loader has an identical API to DuckDBParquetLoader, so test parametrization should be straightforward once the fixture is restored.
- Dominant language
- Python
- Stars
- 28
- Forks
- 17
- Avg merge
- 8h 50m
- Merged PRs (30d)
- 2
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from uberdeveloper/fastbt
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 48/100
uberdeveloper/fastbt#31 ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 52/100
uberdeveloper/fastbt#30 ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 48/100
uberdeveloper/fastbt#28 ·
-
FB-008: close_trade mixes price and tick; stale exits are silent (zero-P&L fallback) [silent-wrong]Openbug
Difficulty 3/5 1-2 days Newbie friendliness 70/100
uberdeveloper/fastbt#27 ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 55/100
uberdeveloper/fastbt#26 ·
All issues in uberdeveloper/fastbt
Similar issues
-
area:core-platform effort:S priority:P3 status:in-review type:test
Difficulty 2/5 Under an hour Newbie friendliness 80/100
randomparity/kdive#3246 · 1 comment ·
Maintainers usually reply within 1 day
-
Requantification library converts m/z to mass with the hydrogen-atom mass instead of the proton massOpenbug
Difficulty 1/5 Under an hour Newbie friendliness 85/100
nf-core/metaboigniter#130 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
common-workflow-language/cwl-utils#477 ·
Maintainers usually reply within 1 day
-
Add dependabotOpenfeat
Difficulty 2/5 Under an hour Newbie friendliness 72/100
open-nudge/opentemplate#204 ·
Maintainers usually reply within 1 day
-
github-stale-ci-pr-closer: KV state is double-wrapped, never persists, and hits the depth-32 limitPossibly taken @VascoSch92 claimed this today. Openpriority:medium ready-for-dev
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
OpenHands/extensions#781 ·
Maintainers usually reply within 1 day