Dark and Dark Vibrant: comments and line numbers are 3.66:1 on the editor background

Open
#20 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
Half a day
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
typescript, vscode

Research direction

The payload names no files, so begin by finding where the theme's gray palette values are mapped to syntax.comment, editorLineNumber.foreground, placeholder input colours and terminal.ansiBlack/ansiBrightBlack in the dark, dark vibrant and light variants. Check the proposed gray swaps against the listed contrast ratios with a contrast checker. Done when the dark roles reach 4.5:1 and the light placeholder choice is settled, which the issue leaves open between gray 600 and gray 700.

Written by the indexing model from the issue text.

Description

accessibility

syntax.comment and editorLineNumber.foreground use gray 600 (#636c74) on #0b0c0d: 3.66:1, below the 4.5:1 minimum for text (WCAG 1.4.3). The same colour is used for markdown quotes and list bullets and for inactive tab, title bar and panel labels (3.45:1 on #131415), the placeholder text of inputs is at 2.40:1 (gray 700 on #18191a), and terminal.ansiBlack/ansiBrightBlack are equal to the terminal background (1.0:1).

gray 500 (#77828c) gives 4.99:1 on the editor and 4.70:1 on #131415. Proposal: use gray 500 for those roles (placeholder: gray 400 for margin, 6.16:1). Comments would be a little more prominent. Light themes are not affected for comments (gray 600 is 5.35:1 on white), but the light placeholder (gray 500, 3.25:1 on #e8eaec) needs gray 600 (4.43:1, still marginal; gray 700 gives 6.4).

🤖 Generated with Claude Code

Dominant language
TypeScript
Stars
7
Forks
2
Avg merge
3h 2m
Merged PRs (30d)
6

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from twbs/bootstrap-vscode-theme

All issues in twbs/bootstrap-vscode-theme

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.