Problem: bridge config is hardcoded
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 25/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- go
- Domain
- backend, blockchain, databases
Research direction
Start by locating the ERC20 bridge actions and the network configurations that are currently hardcoded. Review how database-owned configuration and CI or test-node setup are handled, then define the table and update path before adding coverage for the configurable behavior.
Written by the indexing model from the issue text.
Description
hey @williamrusdyputra, since you are owning more of the code of erc20 implementation, can you analyze some suggestions?
My aim here is to make sure we have tests available to cover the implementation.
I see that some actions hardcode configurations of each network. I propose we make this configurable by adding a table network_bridge_config with columns
- fee
- treasure_address
- chain_name
this should only be updated by the db_owner, and would make it more testable in ci tests and test nodes, etc.
It would be better if even the action could accept the alias as a parameter so we could call things like {chain_name}.bridge dynamically. But doesn't seem possible, in the worst case, we would still need to add a bunch of if ... else to have a statement for each chain. The idea is just to have less surface of code for fewer tests.
What do you think about this? Then we can start covering more critical parts with tests
I can take this issue if it aligns with the goal
- Dominant language
- Go
- Stars
- 7
- Forks
- 3
- Avg merge
- 11h 39m
- Merged PRs (30d)
- 12
Getting set up
- Ships a Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from trufnetwork/node
-
type: goal
Difficulty 5/5 Over a week Newbie friendliness 35/100
trufnetwork/node#1436 ·
Maintainers usually reply within 1 day
-
Problem: settlement can't tell a capture was taken too earlyPossibly taken @MicBun claimed this 16 days ago. Open
trufnetwork/node#1435 · 1 assignee ·
Maintainers usually reply within 1 day
-
Goal: SDK call for market volume over a time periodPossibly taken @vinarmani claimed this 17 days ago. Open
trufnetwork/node#1429 · 2 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
trufnetwork/node#1313 · 2 comments · 1 reaction ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 35/100
trufnetwork/node#1200 · 1 comment ·
Maintainers usually reply within 1 day
All issues in trufnetwork/node
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
AOSSIE-Org/DebateAI#611 ·
Maintainers usually reply within 3 days
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
MHSanaei/3x-ui#6737 · 1 comment ·
Maintainers usually reply within 1 day
-
terraform-provider
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
ClickHouse/terraform-provider-clickhousedbops#281 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
open-telemetry/opentelemetry-go-compile-instrumentation#1450 ·
Maintainers usually reply within 2 days