A file dropped just before the window is minimized can be imported more than once

Open Beginner friendly
  • Is something wrong?
#369 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
rust
Domain
audio-video-rtc, desktop

Research direction

Start with the frame loop's logic-only tick and the drop routing tests mentioned in the issue. Trace how raw input is routed after a file drop, then add a guard or clear the dropped files after the first routing so later ticks do not process them again. Add a regression test showing that a drop is routed only once when the window is minimized, and run the drop routing tests.

Written by the indexing model from the issue text.

Description

bug

While the window is minimized or hidden, the frame loop's logic-only tick re-reads the previous pass's raw input. If a file drop arrived in that last pass, each tick sees it again: before #368 the old code re-imported it; with the drop router it would queue duplicates. Reaching it needs a minimize within about a second of a drop. Low priority; the fix is a small guard that marks a raw-input pass as consumed once routed (or clears the dropped files after the first routing), with a test in the drop routing tests.

Dominant language
Rust
Stars
8
Forks
1
Avg merge
10h 27m
Merged PRs (30d)
3

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from transit-audio/transit

All issues in transit-audio/transit

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.