admin1Code, admin2Code are returned as string instead of object in API response
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 25/100
- Issue type
- Bug
- Clarity
- Needs clarification
- Activity status
- Stale
- Tech stack
- javascript, node.js
Research direction
Start by running the two curl requests in the issue and compare the admin1Code and admin2Code response shapes. Trace the geocode API response construction to determine whether the string values are expected; done means resolving the behavior consistently and verifying both reproductions.
Written by the indexing model from the issue text.
Description
Hi Thomas,
Thank you for building this extremely useful application! We have been using it in our app for a few months now, and the results have been accurate 99% of the time.
I noticed that in some cases, the admin1Code or admin2Code returns a string instead of an object. Is this expected behaviour? Here are the requests to reproduce the issue:
- "admin1Code" : "00"
curl --location 'http://SERVER_URL/geocode?latitude=-16.48679&longitude=-151.74102'
- "admin2Code" : "00"
curl --location 'http://SERVER_URL/geocode?latitude=52.51667&longitude=13.36667'
Please let me know if you need any other information.
- Dominant language
- JavaScript
- Stars
- 217
- Forks
- 60
- PR merge metrics
- No merged PRs in 30d
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- No contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tomayac/local-reverse-geocoder
-
enhancement help wanted
Difficulty 4/5 3-5 days Newbie friendliness 35/100
tomayac/local-reverse-geocoder#24 · 7 comments ·
All issues in tomayac/local-reverse-geocoder
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
enhancement good first issue hacktoberfest help wanted
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
BinaryBaconLabs/todo-app#14 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
liberation-data/drivine#428 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
celestiary/web#345 ·
Maintainers usually reply within 1 day