Pass the workspace_builder to plugin hooks instead of the tmux session
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
Research direction
No files or tests are named. Start by locating the plugin hooks and comparing their current session argument with the workspace_builder interface; clarify the compatibility approach with maintainers. Done means hooks can access workspace configuration through workspace_builder without leaving the chosen legacy-hook behavior ambiguous.
Written by the indexing model from the issue text.
Description
First of all, thank you for this app that changed my life with tmux !
In the current plugin system, it seems impossible to access the session configuration (from yaml or json).
Is there a specific reason the workspace is not passed in the hooks ?
...This would allow to easily extend the configuration file format.
I suggest to replace the session argument with a workspace_builder argument (which already gives access to the session) in the hooks. The drawback is that it's a breaking change. Here are some ways to overcome it:
- Duplicate the hooks
- Have the new hook call the legacy one by default
- Call both the hooks
- Add a new plugin class with hooks expecting the workspace builder
I can of course make a PR myself, but I need to know which way you prefer
- Dominant language
- Python
- Stars
- 4.6k
- Forks
- 247
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tmux-python/tmuxp
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
tmux-python/tmuxp#1026 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
tmux-python/tmuxp#939 · 1 comment ·
-
enhancement WorkspaceBuilder
Difficulty 4/5 3-5 days Newbie friendliness 48/100
tmux-python/tmuxp#1062 ·
-
enhancement need-comments WorkspaceBuilder
Difficulty 5/5 Over a week Newbie friendliness 35/100
tmux-python/tmuxp#1058 · 2 comments ·
-
Very slow performance opening layouts/workspacesPossibly taken A pull request linked to this issue is open or already merged. Openbug
Difficulty 4/5 3-5 days Newbie friendliness 45/100
tmux-python/tmuxp#1053 · 10 comments ·
All issues in tmux-python/tmuxp
Similar issues
-
needs-human needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
gke-labs/kube-agents#2400 · 1 comment ·
Maintainers usually reply within 1 day
-
Device Details tables: FS/SF columns contradict each other (nfet_01v8 Vt row, pfet_01v8 Idsat row)Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
google/skywater-pdk#450 ·
-
Drained trajectory arrays are overwritten when the sequence buffer is reusedPossibly taken @sylvesterkaczmarek claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
google-deepmind/bsuite#56 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
LearningCircuit/local-deep-research#7206 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
chingu-voyages/V62-tier3-team-33#285 ·
Maintainers usually reply within 1 day