[Bug]: Database path is put into a sqlite:// URL without escaping

Open Beginner friendly
#118 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
85/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust, sqlite
Domain
database

Research direction

Start at src/db.rs line 11, where db::open builds sqlite://{path} and parses it with from_str. Read the surrounding function to see how the path and options are used, then construct SqliteConnectOptions::new().filename(path) instead of parsing a URL. Done when a data directory containing ?, # or % opens the intended file and existing db tests still pass.

Written by the indexing model from the issue text.

Description

bug

[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.

Version

0.40.0 (feat/desktop, 017a837b)

Area

Config

What happened?

db::open builds sqlite://{path} with format! and parses it (src/db.rs:11). A data directory containing ?, # or % is read as URL syntax and opens the wrong file or fails.

Steps to reproduce

Use a data directory like /srv/media?test and start the server.

Expected behavior

Any directory name works.

Suggested fix

SqliteConnectOptions::new().filename(path) instead of from_str.

Dominant language
TypeScript
Stars
4
Forks
1
Avg merge
4h 49m
Merged PRs (30d)
5

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tinystream-dev/tinystream

All issues in tinystream-dev/tinystream

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.