[Bug]: Long-running watch-together rooms can lose their database row

Open Beginner friendly
#116 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
backend

Research direction

Open src/together.rs at the cleanup around line 652 that deletes watch_rooms rows by last_active, and read it next to save, which the issue says is the only writer of last_active (on episode/settings changes and room empty). Then find how the in-memory room registry exposes whether a room is currently occupied, since the fix either skips those codes in the cleanup or touches last_active for them on the hourly tick. Done means a room that stays occupied past 7 days keeps its row across a restart. No test path is named, so check how cleanup is currently exercised before changing it.

Written by the indexing model from the issue text.

Description

bug

[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.

Version

0.40.0 (feat/desktop, 017a837b)

Area

Streaming / playback

What happened?

The hourly cleanup deletes watch_rooms rows whose last_active is older than 7 days (src/together.rs:652), but last_active is only written by save, which runs on episode or settings changes and when the room empties. A room that stays occupied for over 7 days without those has its row deleted while it's live; later saves update nothing and the room is gone after a restart.

Expected behavior

Rooms in use are never cleaned up.

Suggested fix

Skip codes of non-empty in-memory rooms in the cleanup, or touch last_active for occupied rooms on the hourly tick.

Dominant language
TypeScript
Stars
4
Forks
1
Avg merge
4h 49m
Merged PRs (30d)
5

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tinystream-dev/tinystream

All issues in tinystream-dev/tinystream

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.