[Bug]: Streaming can buffer a whole file's audio before the first keyframe

Open
#114 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
52/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust

Research direction

Start in src/media/stream.rs around line 322, where audio packets accumulate in held_audio until the first video keyframe sets video_start; trace both where video_start is assigned and where held_audio is later drained, in copy mode. Decide on a bound (packet count or duration) or a timeout for giving up on the keyframe, and keep the existing A/V sync behaviour intact. Done means memory stays bounded for a file with no keyframe flag or a far seek, verified by a test or a synthetic input rather than a live server, since the report was not reproduced.

Written by the indexing model from the issue text.

Description

bug

[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.

Version

0.40.0 (feat/desktop, 017a837b)

Area

Streaming / playback

What happened?

In copy mode, audio packets wait in held_audio until the first video keyframe sets video_start (src/media/stream.rs:322). The vector has no limit, so for a file whose video packets never carry the keyframe flag (or a seek that lands far from one), the stream reads the whole file's audio into memory.

Expected behavior

Memory use stays bounded however the file is laid out.

Suggested fix

Cap held_audio (by count or duration) and drop the oldest packets, or give up waiting for a keyframe after a few seconds of input.

Dominant language
TypeScript
Stars
4
Forks
1
Avg merge
4h 49m
Merged PRs (30d)
5

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tinystream-dev/tinystream

All issues in tinystream-dev/tinystream

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.