[Bug]: Subsonic token logins and API keys aren't rate limited

Open Beginner friendly
#104 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
74/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust

Research direction

Start at sign_in in src/api/subsonic/mod.rs (around line 225), where the t/s token branch and the apiKey branch skip throttle.guess. Read the plain-password branch just above to see the existing guess/right pattern, then apply it to both paths. Done means a loop of /rest/ping?u=<real user>&t=<random>&s=x eventually returns throttling instead of endless error 40, and a valid token or key calls state.throttle.right(ip). Note the reporter has not run a server, so verify against the existing subsonic test setup.

Written by the indexing model from the issue text.

Description

bug

[!NOTE]
This issue was written by Claude (Claude Opus 5.5) from a code review session with @PhrolovaMoe. It was found by reading the code and hasn't been reproduced on a running server.

Version

0.40.0 (feat/desktop, 017a837b)

Area

Other

What happened?

In the Subsonic API's sign_in, only plain-password attempts and unknown usernames spend a throttle guess. The t/s token path (src/api/subsonic/mod.rs:225) and the apiKey path never call throttle.guess, so app passwords and API keys can be guessed as fast as the server answers.

Steps to reproduce

Send /rest/ping?u=<real user>&t=<random>&s=x in a loop: every request gets error 40 and none get throttled.

Expected behavior

Wrong tokens and API keys spend a guess like wrong passwords do, and right ones give it back.

Suggested fix

Call state.throttle.guess(ip) before checking a token or API key and state.throttle.right(ip) when it matches.

Dominant language
TypeScript
Stars
4
Forks
1
Avg merge
4h 49m
Merged PRs (30d)
5

Getting set up

  • Ships a Dockerfile or Docker Compose file
  • No pull request template
  • No contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tinystream-dev/tinystream

All issues in tinystream-dev/tinystream

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.