usecase-shape misses property-read and chained forwarders
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- Half a day
- Newbie friendliness
- 55/100
Research direction
Start with isForwarder in PresentationRules.kt, the usecase-shape check, and read how it currently matches a single call on a constructor property. Then look at the three named use cases (ReadLastScanDate, ReadEqualizerPreset, ObserveScannerFolders) and the baseline file. Done means the check flags property-read, chained, this., generic and dotted-receiver forwarders, and those three are either removed or baselined with the check passing.
Written by the indexing model from the issue text.
Description
The usecase-shape forwarder check added in PresentationRules.kt (isForwarder) catches only a single method call on a constructor property. It misses:
- property-read forwarders (
= folderStore.folders), soReadLastScanDate,ReadEqualizerPresetandObserveScannerFoldersstay as forwarders - chains other than
.flowOn(..)and.first() - calls through
this., explicit generics or dotted receivers - forwarding to a property that isn't a constructor parameter
Fix: widen isForwarder to cover these, then delete or baseline the three remaining forwarders.
- Dominant language
- Kotlin
- Stars
- 231
- Forks
- 28
- PR merge metrics
- No merged PRs in 30d
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from timusus/Shuttle2
-
support/scripts/asc: S2 bundle id resolves to the Podcasts app (bundleId filter is a prefix match)Openbug next-release
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
bug design impact:U1 later P3 reach:R2 size:S
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
enhancement impact:U1 later P3 reach:R2 size:S
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
impact:U1 owner reach:R1 size:S
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
idea
Difficulty 5/5 Over a week Newbie friendliness 25/100
All issues in timusus/Shuttle2
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 67/100
Maintainers usually reply within 1 day
-
app
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
LawnchairLauncher/lawnicons#4180 ·
Maintainers usually reply within 1 day
-
afk-ok area:agents size:S
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
enorm-labs/event-junkie#3523 ·
Maintainers usually reply within 1 day
-
submit-adaption submit-adaption-pre
Difficulty 1/5 Under an hour Newbie friendliness 82/100
BetterAndroid/android-notification-icon-project#750 · 1 comment ·
Maintainers usually reply within 1 day