Fix the broken `--factory` echo example

Open Beginner friendly
  • Is something wrong?
#40 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
83/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
python
Domain
backend

Research direction

Start with examples/echo_http/app.py and compare its exports with the factory target in docs/ops/cli.md, README.md, and PYPI_README.md. Add a zero-argument factory returning the existing ASGI app and update the documented commands to use it. Run the documented factory command from the checkout; done when an empty HTTP request returns 200 with body echo: and the direct app launch still works.

Written by the indexing model from the issue text.

Description

good first issue

The documented factory launch uses examples.echo_http.app:create_app, but the example module only defines app.

Acceptance criteria

  • Provide a zero-argument factory returning the example ASGI app and make the documented commands point to it.
  • Run the documented factory command from the checkout and verify an empty HTTP request returns 200 with body echo:.
  • Keep the direct examples.echo_http.app:app launch working.

Relevant files

Dominant language
Python
Stars
3
Forks
3
Avg merge
7h 59m
Merged PRs (30d)
8

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tigrbl/tigrcorn

All issues in tigrbl/tigrcorn

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.