Fix failing expectation in tests.test_phase9g_strict_performance_closure

Open
  • Is something wrong?
#19 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
1-3 hours
Newbie friendliness
55/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
testing

Research direction

Read tests/test_phase9g_strict_performance_closure.py, especially test_preserved_artifacts_validate_and_promotion_report_performance_section_is_green, then run the reproduction command. Check the promotion report's performance section to confirm whether report.passed should be true, and align the assertion with that behavior. Done when all four tests in the module pass.

Written by the indexing model from the issue text.

Description

good first issue

Summary

tests.test_phase9g_strict_performance_closure has a failing assertion in test_preserved_artifacts_validate_and_promotion_report_performance_section_is_green.

Reproduction

uv run python -m unittest -v tests.test_phase9g_strict_performance_closure

Current result

  • Ran: 4 tests
  • Failures: 1
  • Failing test:
    • test_preserved_artifacts_validate_and_promotion_report_performance_section_is_green

Failure details

At:

  • tests/test_phase9g_strict_performance_closure.py:74

Assertion:

self.assertFalse(report.passed)

Observed:

  • report.passed is True
  • failure: AssertionError: True is not false

Notes

Other tests in the same module are currently passing, which suggests this is likely expectation drift in this assertion versus the current promotion evaluator/report behavior.

Acceptance criteria

  • Align test expectation with intended current behavior of the promotion report performance section.
  • uv run python -m unittest -v tests.test_phase9g_strict_performance_closure passes.
Dominant language
Python
Stars
3
Forks
3
Avg merge
7h 59m
Merged PRs (30d)
8

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tigrbl/tigrcorn

All issues in tigrbl/tigrcorn

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.