melodie-swtich: Column order for `tune_results$.predictions` changed
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- r
- Domain
- testing-qa
Research direction
Review the listed survival tests: tests/testthat/test-survival-tune-grid.R, test-survival-tune-bayes.R, and test-survival-tune-sa.R. Start with the first three Bayesian tests and compare the expected names of each .predictions data frame with the reported actual order. The work is done when the affected tests consistently pass with the intended column order.
Written by the indexing model from the issue text.
Description
With https://github.com/tidymodels/tune/tree/melodie-switch:
The .predictions data frame of a tune_results object has a different column order now. It affects censored regression.
tests/testthat/test-survival-tune-grid.Rtests/testthat/test-survival-tune-bayes.R(first 3 tests)tests/testthat/test-survival-tune-sa.R
> expect_equal(
+ names(bayes_static_res$.predictions[[1]]),
+ c(".pred_time", ".row", "tree_depth", "event_time", ".config")
+ )
Error:
! names(bayes_static_res$.predictions[[1]]) (`actual`) not equal to c(".pred_time", ".row", "tree_depth", "event_time", ".config") (`expected`).
`actual`: ".pred_time" ".row" "event_time" "tree_depth" ".config"
`expected`: ".pred_time" ".row" "tree_depth" "event_time" ".config"
- Dominant language
- R
- Stars
- 23
- Forks
- 0
- Avg merge
- 55m
- Merged PRs (30d)
- 2
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tidymodels/extratests
-
feature
Difficulty 4/5 3-5 days Newbie friendliness 45/100
tidymodels/extratests#303 ·
-
upkeep
Difficulty 4/5 3-5 days Newbie friendliness 25/100
tidymodels/extratests#270 ·
-
bug upkeep
Difficulty 4/5 3-5 days Newbie friendliness 35/100
tidymodels/extratests#254 ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
tidymodels/extratests#253 ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 35/100
tidymodels/extratests#252 ·
All issues in tidymodels/extratests
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
Rdatatable/data.table#7952 ·
Maintainers usually reply within 1 day
-
priority: could techdebt
Difficulty 1/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
microsoft/ML-For-Beginners#1061 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
Rapporteket/rapbase#535 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100