NoticeBar component should have a built-in prop for adding a close button

Open Beginner friendly
#354 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 3 days

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Domain
frontend

Research direction

Start from the NoticeBar component in services-ui and look at how it renders today, then find the close icon the issue says already exists elsewhere in the library. Add an opt-in prop that shows the close button and emits an event on click so callers can clean up. Done when the button appears only when the prop is set and the event fires on click.

Written by the indexing model from the issue text.

Description

We already have a close icon built into services-ui and this is a very common pattern.

Note that usages of the close button are sometimes tied to a specific prop / variable from the caller so it would be nice to emit an event when the button clicks so callers can clean up whatever is needed upon dismissal.

Dominant language
Vue
Stars
10
Forks
1
Avg merge
1d 22h
Merged PRs (30d)
5

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from thunderbird/services-ui

All issues in thunderbird/services-ui

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.