base_tsa: Allow "translation" of replay file names
@32th-System is already working on this.
Since Jan 16, 2020.
Assessment
This issue has not been assessed yet.
Description
Modders usually want to change the game in more drastic ways than translators - adding new dialogue scripts with new text boxes, modifying danmaku scripts, or even changing parameters of shot types. All of these break existing replays recorded on the unpatched game. This would require players to closely keep track of the patches used for each replay.
By allowing patches to change the replay file name format used by the game, we easily eliminate this confusion.
The straightforward solution would require location of the replay format strings, and probably a new safe sprintf hack for each game. Automatically constructing such a new pattern from the patch stack might also be worth a thought.
Completion status (the list entries for all the ZUN games will be added as I go)
- TH06: https://github.com/thpatch/thcrap-tsa/commit/3ba69cb785e317b5ec6845feea2138a69938981f https://github.com/thpatch/thcrap-tsa/commit/e3fc307a51efff90b62dedf019e0d7cf43f2558c
- TH07: https://github.com/thpatch/thcrap-tsa/commit/3ff65808a7500ccdd2ea87add0fa1a7092729a17
- TH75 (Tasofro)
- TH08 https://github.com/thpatch/thcrap-tsa/commit/31fc5b14814c09dbdc4857eb1c616ce6d4b4004c
- TH09 https://github.com/thpatch/thcrap-tsa/commit/b29f7241ecd2a7532dc624949a36d6430d0268ef https://github.com/thpatch/thcrap-tsa/commit/d8a7a274925e30b021a4f7d701dcbc65bf37546a
- TH95
- TH10 https://github.com/thpatch/thcrap-tsa/commit/e61ae833333f53e028d06dc4ec0fa4cbf12fcfeb https://github.com/thpatch/thcrap-tsa/commit/abe47202ad30de163e72800f5052a11e3289d5fa
- TH105 (Tasofro)
- TH11 https://github.com/thpatch/thcrap-tsa/commit/6c4a28e8036696130e0c9fe2fb7392b6f02a341a
- TH12 https://github.com/thpatch/thcrap-tsa/commit/52a5cf4bc7d9084e4a3c5b69fcfc630f85f77c8d
- TH123 (Tasofro)
- TH125
- TH128
- TH13 https://github.com/thpatch/thcrap-tsa/commit/b2f398ee1f3045d2940fdff198a8b2dec5a3f585
- TH135 (Tasofro)
- TH14 https://github.com/thpatch/thcrap-tsa/commit/a3b22a21d5388490c599141f9b042738a6eb75a7 https://github.com/thpatch/thcrap-tsa/commit/ad62b647cdc81465378dbb47fb91b851fae94b26 https://github.com/thpatch/thcrap-tsa/commit/3755330ad3994b6b33f4fd7d305707aec58b1981
- TH143
- TH145 (Tasofro)
- TH15 https://github.com/thpatch/thcrap-tsa/commit/1786a24ea10e5acecb88eb6c56de2ec16dd9fb21
- TH155 (Tasofro)
- TH16 https://github.com/thpatch/thcrap-tsa/commit/ec2aad4b797bcd51da7dd5e521ff6cf21dcf7902
- TH165 https://github.com/thpatch/thcrap-tsa/commit/94070f9d4d7bf07bd47b908646e0401e90783622
- TH17 https://github.com/thpatch/thcrap-tsa/commit/ec2aad4b797bcd51da7dd5e521ff6cf21dcf7902
- TH175 (Tasofro)
- TH18 https://github.com/thpatch/thcrap-tsa/commit/965418b7df8f141fe5eeb4382f8b27f7dd6b6965 https://github.com/thpatch/thcrap-tsa/commit/8cc25674a57a1b6371c8fd039b8d5ab21aea38f9
Additional notes:
-
so far I noticed that TH06 and TH07 will copy the file name into a buffer with a fixed size... of 512 bytes which is more than twice the size of a buffer with size MAX_PATH
-
th125 will concatenate the path to it's appdata directory with the scorefile name into a separate buffer on the stack.
-
A game being marked as (Tasofro) doesn't mean adding the replay and scorefile name stringlocs is something @brliron has to do. If anything, he might only have to help me out a little
- Dominant language
- JavaScript
- Stars
- 27
- Forks
- 15
- Avg merge
- 4h 19m
- Merged PRs (30d)
- 2
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from thpatch/thcrap-tsa
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
thpatch/thcrap-tsa#127 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
thpatch/thcrap-tsa#126 ·
-
Trial supportOpen
Difficulty 4/5 3-5 days Newbie friendliness 35/100
thpatch/thcrap-tsa#125 ·
-
minor
Difficulty 3/5 1-2 days Newbie friendliness 45/100
thpatch/thcrap-tsa#124 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
thpatch/thcrap-tsa#118 ·
All issues in thpatch/thcrap-tsa
Similar issues
-
[quality] useFocusTrap's Shift+Tab wrap and non-Tab/non-Escape key arms are never driven end to endPossibly taken @hivecommons-hive claimed this today. Openagent/quality hive/covered-by-pr hive/hosted-available-lke648397-260827-5n31 quality testing
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
Maintainers usually reply within 1 day
-
agentic-workflows
Difficulty 1/5 Under an hour Newbie friendliness 85/100
githubnext/gh-aw-workshop#4220 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
JuliusBrussee/caveman#1189 ·
Maintainers usually reply within 1 day
-
priority:low ready-for-dev
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
OpenHands/extensions#738 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
invoiceninja/invoiceninja#13320 ·
Maintainers usually reply within 1 day