Merge guidance omits required AOT and Engine checks

Open Beginner friendly
  • Is something wrong?
#7,444 1 comment 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Active
Tech stack
csharp, git, github
Domain
documentation

Research direction

The mismatch lives in .agents/skills/issue-pr-loop/references/repository.md, in the Merge gate section, which lists two required checks for main. Compare that list against the live branch protection output from gh api repos/thomhurst/TUnit/branches/main/protection, which the issue says requires eight checks across Ubuntu, Windows and macOS. Done means the guide matches the live configuration or points readers to the API as the source of truth, with no change to the merge wrapper's validation.

Written by the indexing model from the issue text.

Description

documentation P3

Summary

The issue/PR loop's repository guidance lists only two required CI checks for main, while GitHub currently requires eight. Update the guidance so agents assessing merges have an accurate account of the branch protection.

Reproduction

Read .agents/skills/issue-pr-loop/references/repository.md, Merge gate, on main at d8badacb13. Compare its two-check list against gh api repos/thomhurst/TUnit/branches/main/protection.

Expected and actual

The guide should describe the current required checks, or point to the live protection API as authoritative. The API currently requires modularpipeline on Ubuntu/macOS, Engine tests on Ubuntu/Windows/macOS, and AOT on Ubuntu/Windows/macOS; the guide lists only modularpipeline on Ubuntu/macOS. The merge wrapper still checks all checks, so this documentation mismatch did not bypass validation for #7406.

Please align the merge guidance with the live protection configuration.

Dominant language
C#
Stars
4k
Forks
139
Avg merge
9h 6m
Merged PRs (30d)
282

Getting set up

Open in Codespaces

Starts the project's dev container in your browser, under your own GitHub account.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from thomhurst/TUnit

All issues in thomhurst/TUnit

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.