no retries on HTTP 5xx errors
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 67/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- python
- Domain
- networking
Research direction
Find Urllib3Fetcher and inspect how it configures the PoolManager and urllib3 retries; check the existing fetcher tests for retry behavior. Add retries for HTTP 502, 503, and 504 responses, then verify those cases are covered by the tests.
Written by the indexing model from the issue text.
Description
Urllib3Fetcher ends up using a PoolManager that uses the default Retry(total=3) which has status_forcelist=set(): This means 502/503/504 responses without a Retry-After header are not retried.
I think this is overly cautious: I think we can retry those.
In practice this would make sigstore-python a little more reliable as sigstores TUF repo runs on Google Cloud GCS which does not include Retry-After on 504s but often works on a retry if a 504 happens
- Dominant language
- Python
- Stars
- 1.7k
- Forks
- 306
- Avg merge
- 4d 40m
- Merged PRs (30d)
- 12
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from theupdateframework/python-tuf
-
Metadata API: SuccinctRoles.is_delegated_role() accepts non-canonical bin namesPossibly taken @Anandb71 claimed this 23 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 42/100
theupdateframework/python-tuf#3033 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
theupdateframework/python-tuf#3001 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 42/100
theupdateframework/python-tuf#2979 · 1 comment ·
Maintainers usually reply within 1 day
-
enhancement github_actions
Difficulty 3/5 1-2 days Newbie friendliness 45/100
theupdateframework/python-tuf#2920 · 1 comment · 2 reactions ·
Maintainers usually reply within 1 day
-
Investigate/test fetcher retriesPossibly taken @ishaanxgupta claimed this 308 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 35/100
theupdateframework/python-tuf#2842 · 3 comments ·
Maintainers usually reply within 1 day
All issues in theupdateframework/python-tuf
Similar issues
-
question
Difficulty 1/5 Under an hour Newbie friendliness 68/100
vllm-project/vime#524 ·
Maintainers usually reply within 7 days
-
WOPI editor page is scrollable by a few pixels, which breaks scrolling in the document (Firefox)Open
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
suitenumerique/drive#969 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
FAIRmat-NFDI/pynxtools#861 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
NVIDIA/nsight-python#88 ·
Maintainers usually reply within 1 day
-
Criteria can pass when the deliverable is missingPossibly taken @clementtisseau claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
harveyai/harvey-labs#217 ·
Maintainers usually reply within 2 days