Show extension dialogs inline in the chat, not as a popup

Open
#161 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Active
Tech stack
typescript
Domain
frontend

Research direction

Start by reviewing the chat-ask PR and how extension dialogs currently open as popups. Decide which presentation to use: inline prompts persisted until answered, a hideable popup, or a side panel. Then implement the chosen form, including persistence and transcript recording if inline, and add browser tests that verify the chosen behavior and confirm the old popup behavior is gone.

Written by the indexing model from the issue text.

Description

enhancement later

Problem

Extension dialogs (confirm, choose, text prompts from extensions) still open as a popup over the whole page. Without context they can be confusing, especially when one opens out of nowhere while the person is somewhere else in the chat.

The agent's ask_question questions are being moved inline and kept on the server (see the chat-ask PR). Extension dialogs stay popups until we decide how they should look.

Open question

Should extension dialogs also show inline above the composer, like questions, or does a popup fit them better? Options to weigh:

  • Inline in the chat, kept on the server until answered, the same as questions.
  • A popup that can be hidden and reopened from the chat.
  • A separate side panel for prompts (probably too much).

Scope when decided

  • Same persistence and transcript record as questions, if inline.
  • Browser tests for the chosen form, and a check that the old popup behaviour is gone.
Dominant language
TypeScript
Stars
297
Forks
81
Avg merge
8h 47m
Merged PRs (30d)
167

Getting set up

This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from thecodacus/pithagoras

All issues in thecodacus/pithagoras

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.