Take named options in `PostgreSqlContainer.withSSL`
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 74/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- docker, postgresql, typescript
Research direction
Start with packages/modules/postgresql/src/postgresql-container.ts and inspect PostgreSqlContainer.withSSL alongside withSSLCert and the positional overloads coordinated with #1518. Add the named-fields form while preserving the positional forms as deprecated overloads. Done when callers can pass { cert, key, ca } and the existing positional signatures remain available as deprecated overloads.
Written by the indexing model from the issue text.
Description
What happens
PostgreSqlContainer has two SSL methods that take the same three file paths in different positions:
withSSL(certFile: string, keyFile: string, caCertFile?: string)
withSSLCert(caCertFile: string, certFile: string, keyFile: string)
All three are plain strings, so passing them in the wrong order compiles. The mistake shows up only when the server fails to start or a client fails to verify.
Expected
A form with named fields, for example withSSL({ cert, key, ca }), with the positional forms kept as deprecated overloads.
Where
packages/modules/postgresql/src/postgresql-container.ts.
Notes
withSSLCert(caCertFile, certFile, keyFile)matches Go'spostgres.WithSSLCert(caCertFile, certFile, keyFile).withSSLis the one that differs.- Both were added in #1224.
- The same applies to any module method that takes several paths or credentials positionally. Worth a line in the
add-moduleskill.
Dependencies
- Nothing blocks this. It can start now.
- Coordinate with #1518: for the positional overloads.
- Dominant language
- TypeScript
- Stars
- 2.6k
- Forks
- 274
- Avg merge
- 1d 14h
- Merged PRs (30d)
- 44
Getting set up
Starts the project's dev container in your browser, under your own GitHub account.
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from testcontainers/testcontainers-node
-
enhancement minor
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
testcontainers/testcontainers-node#1533 ·
Maintainers usually reply within 1 day
-
enhancement minor
Difficulty 2/5 1-3 hours Newbie friendliness 77/100
testcontainers/testcontainers-node#1531 ·
Maintainers usually reply within 1 day
-
enhancement minor
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
testcontainers/testcontainers-node#1529 ·
Maintainers usually reply within 1 day
-
enhancement minor
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
testcontainers/testcontainers-node#1528 ·
Maintainers usually reply within 1 day
-
bug patch
Difficulty 2/5 1-3 hours Newbie friendliness 79/100
testcontainers/testcontainers-node#1526 ·
Maintainers usually reply within 1 day
All issues in testcontainers/testcontainers-node
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
status:approved type:bug
Difficulty 1/5 Under an hour Newbie friendliness 70/100
egdev6/quorb#109 · 1 comment ·
Maintainers usually reply within 1 day
-
stage:4
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
ilan-pinto/roaring-lions#598 ·
Maintainers usually reply within 1 day
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 1 day
-
Frontmatter next to `src:` is applied to every imported slide, not only the first (undocumented)Open
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day