[Bug] Worker task slots used/available off-by-one error
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 38/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- rust
- Domain
- backend, distributed-systems
Research direction
Start with core/src/abstractions.rs at the linked line, then trace worker task-slot permit release and eviction handling. Reproduce workflow completion and eviction scenarios, and verify that used and available metrics remain consistent and permits are held until eviction completes.
Written by the indexing model from the issue text.
Description
It's sometimes possible for, after fully completing a workflow, for WFT used metric to bet @ 1 and available @ the max still. Possibly also available may be at the max even before an evict is fully complete.
I think this maybe has to do with the special bit of code here https://github.com/temporalio/sdk-core/blob/95db75dc950cf07a99c79e6794172572dd34e6a6/core/src/abstractions.rs#L128 that needs to add one extra sometimes
Additionally slots are released before eviction completes, but we probably don't want that. We should hold on to the permit until eviction is complete, for situations where we had a permit when we generated the eviction.
- Dominant language
- Rust
- Stars
- 542
- Forks
- 172
- Avg merge
- 2d 4h
- Merged PRs (30d)
- 53
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from temporalio/sdk-rust
-
Time-skipping in the Rust SDK's workflow test environmentPossibly taken @GregoryTravis claimed this 3 days ago. Opensdk-rust
temporalio/sdk-rust#1732 · 4 comments · 1 assignee ·
Maintainers usually reply within 1 day
-
S3 External Storage Driver - RustPossibly taken @cconstable claimed this 6 days ago. Opensdk-rust
temporalio/sdk-rust#1709 · 1 assignee ·
Maintainers usually reply within 1 day
-
[Bug] Local Activity retries indefinitely when ScheduleToClose expires between in-process retriesPossibly taken @dannyward630 claimed this 17 days ago. Openbug
Difficulty 4/5 3-5 days Newbie friendliness 30/100
temporalio/sdk-rust#1657 ·
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
temporalio/sdk-rust#1653 ·
Maintainers usually reply within 1 day
-
Enable concurrent payload visiting - RustPossibly taken @jmaeagle99 claimed this 20 days ago. Open
temporalio/sdk-rust#1650 · 1 assignee ·
Maintainers usually reply within 1 day
All issues in temporalio/sdk-rust
Similar issues
-
example
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
rust-lang-nursery/rust-cookbook#954 ·
Maintainers usually reply within 1 day
-
Difficulty 1/5 1-3 hours Newbie friendliness 70/100
OpenZeppelin/openzeppelin-relayer#967 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
src/runs.rs:1987: a missing --source-run-id now answers 400 "Source run ... does not exist", not 404Opennightly-audit
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
antithesishq/snouty#602 ·
Maintainers usually reply within 1 day