fifottl/limfifottl: stop() blocks forever while RW, drop() leaks the TTL fiber
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
Research direction
Start in queue/abstract/driver/fifottl.lua, especially the TTL loop and stop-channel setup referenced at lines 171-177 and 200; compare its lifecycle with utubettl. Reproduce the RW stop and dropped-tube cases from the issue, then verify that stop returns, fibers terminate, and dropping a tube leaves no TTL fiber using the supplied checks.
Written by the indexing model from the issue text.
Description
Environment: queue master (07fd732), Tarantool 3.8.0 (also the same code in 1.5.0). memtx.
Summary
fifottl (and therefore limfifottl) creates its stop channel as an unbuffered fiber.channel() (fifottl.lua#L200), but the TTL fiber only reads it in the box.info.ro == true branch (fifottl.lua#L171-L177). So:
tube.raw:stop()called while the instance is RW blocks the caller forever.fifottlhas nomethod.drop, sotube:drop()never callsstop()at all: the space is dropped and the TTL fiber leaks, one per dropped tube. After the instance becomes RO the leaked fibers sit in thesync_chan:get(0.1)poll loop forever.utubettlusesfiber.channel(1)so itsstop()returns, but the fiber keeps running in RW;utubettl'sdrop()then makes it crash on the dropped space (attempt to index field 'watch' (a nil value)).
Repro
local fiber = require('fiber')
box.cfg{}
local queue = require('queue')
-- 1. stop() blocks while RW
local tube = queue.create_tube('t', 'fifottl')
local done = false
fiber.create(function() tube.raw:stop(); done = true end)
fiber.sleep(1)
print('fifottl raw:stop() returned within 1s:', done) -- false (utubettl: true)
-- 2. drop() leaks the fiber
local function ttl_fibers()
local n = 0
for _, f in pairs(fiber.info()) do if f.name == 'fifottl' then n = n + 1 end end
return n
end
local before = ttl_fibers()
for i = 1, 3 do queue.create_tube('leak_' .. i, 'fifottl'):drop() end
fiber.sleep(0.5)
print('fifottl fibers leaked by 3 drops:', ttl_fibers() - before) -- 3
Output on master:
fifottl raw:stop() returned within 1s: false
fifottl fibers leaked by 3 drops: 3
Expected
stop() returns in both RW and RO mode and the fiber actually terminates; drop() stops the fiber before dropping the space (as utubettl tries to do), and does not leave the fiber running against a dropped space.
Suggested fix
Check a stop flag (or the channel with a zero timeout) in the RW branch of the loop as well, make stop() wait for the fiber to finish before clearing self.fiber, and add method.drop to fifottl that calls stop() first. fifottl should also use a buffered channel like utubettl so stop() cannot block the state machine fiber.
- Dominant language
- Lua
- Stars
- 244
- Forks
- 56
- Avg merge
- 6d 8h
- Merged PRs (30d)
- 1
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from tarantool/queue
-
documentation good first issue
Difficulty 1/5 Under an hour Newbie friendliness 85/100
-
Difficulty 3/5 1-2 days Newbie friendliness 76/100
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
-
1sp bug teamE
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
LandSandBoat/server#11579 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
ArchiveTeam/sinavideo-grab#7 · 3 reactions ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
mailcow/mailcow-dockerized#7480 ·
-
mapper bug
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
documentation feature-request mini.completion
Difficulty 1/5 Under an hour Newbie friendliness 88/100