ci: fix publish dry-run failure states

Open
#483 1 comment 0 reactions 1 assignee View on GitHub

Maintainers usually reply within 1 day

@smmckay is already working on this.

Since Nov 11, 2026.

Assessment

This issue has not been assessed yet.

Description

bug ci/cd

During the release of 0.7.0, we were bitten by the "Publish (Dry run)" step passing despite containing real errors; as a result, the actual "Publish" step failed, and a whole new 0.7.1 release had to be started after correcting the issue[^1]. Note that the "Publish (Dry run)" step runs as part of the "arch-independent checks" job, so we should have caught this weeks ago, but the "Publish (Dry run)" step isn't properly failing when errors occur.

Run with passing "Publish (Dry run)", failing "Publish": https://github.com/tailscale/tailscale-rs/actions/runs/42277910303/job/128110632629
Run from a PR a week ago with the same errors in "Publish (Dry run)": https://github.com/tailscale/tailscale-rs/actions/runs/41872805912/job/126724190632 (search for "no method named")

[^1]: The issue was that smoltcp failed to build without any feature flags enabled, as we had enabled the cubic congestion control feature for smoltcp by default, which in turn requires std. std is an optional feature for smoltcp, and publishing to crates.io requires crates to build without any features enabled, so the overall "Publish (Dry run)" and "Publish" steps failed. This is not the issue we want fixed; it should be fixed upstream in smoltcp's next release.

Dominant language
Rust
Stars
1.2k
Forks
75
Avg merge
1d 13h
Merged PRs (30d)
22

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tailscale/tailscale-rs

All issues in tailscale/tailscale-rs

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.