Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

Client-mode log directory is created under the umask, unlike the daemon's state directory

Open
#297 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
78/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
security

Research direction

Start with daemon::state_perms::ensure_owner_only_dir, then inspect engine::resolve_log_dir and the directory-creation call sites in hyperdb-mcp/src/main.rs and hyperdb-mcp/src/engine.rs. Check how Engine::new passes log_dir to hyperd and consider the adjacent ephemeral data directory. Done means client-mode log directories follow the daemon's owner-only policy, with the related data directory considered consistently.

Written by the indexing model from the issue text.

Description

Summary

The daemon's state directory and logs/ are created with an explicit owner-only mode
(daemon::state_perms, added in #295). The client/local-mode log directory is not: both
call sites use a plain std::fs::create_dir_all, so it takes the process umask — commonly
0755.

That directory holds the same class of file. In local mode Engine::new passes it to hyperd
as the engine's own log_dir, so hyperd writes its diagnostic logs there, and those records
name the endpoint just as the daemon's logs/ do. Restricting the daemon's state directory
while leaving the client's log directory at the umask is an inconsistency rather than a
deliberate difference.

Where

  • engine::resolve_log_dir (hyperdb-mcp/src/engine.rs) returns either the persistent file's
    parent, or std::env::temp_dir().join(format!("hyperdb-mcp-{pid}")) when the session is
    ephemeral.
  • Both call sites create it with a plain create_dir_all:
    • hyperdb-mcp/src/main.rs (client-mode tracing setup, writes hyperdb-mcp.log)
    • hyperdb-mcp/src/engine.rs (Engine::new)
  • Engine::new then sets params.set("log_dir", …) for the local HyperProcess, so hyperd
    rotates its own logs into the same directory.
  • The adjacent ephemeral data directory (hyperdb-mcp-<pid>-<seq>, holding the session's
    .hyper files) is created the same way and is worth considering in the same pass.

Why it varies by platform

The ephemeral case is the one that matters, and how much depends on the platform:

  • Linux — temp_dir() is /tmp, which is shared and world-traversable, and the directory
    name is just the pid. This is the case worth fixing.
  • macOS — temp_dir() is a per-user /var/folders/… directory that is already 0700, so
    the parent covers it.
  • Windows — the per-user temp directory sits inside the user profile and inherits its ACL.

Suggested fix

Reuse daemon::state_perms::ensure_owner_only_dir at both call sites instead of
create_dir_all. It already creates at 0700, tightens a pre-existing directory, sweeps the
regular files inside it, and warns rather than failing when the filesystem has no modes to set
— the same policy the daemon paths use, which is what makes this a consistency fix rather than
a new one. Consider the ephemeral data directory too.

Notes

  • Ordinary file-permission hygiene, not an urgent defect: on macOS and Windows the enclosing
    directory already restricts access, and on Linux it affects a local developer tool's own
    diagnostic output.
  • Deliberately out of scope for #295, which is about the daemon's state directory.
  • Whether the client's own hyperdb-mcp.log records the endpoint was not established —
    no tracing call in engine.rs, server.rs or main.rs emits it as a field, though the
    endpoint does appear in the text of a connect-failure message. The hyperd logs in the same
    directory are the clear case, and they are enough to motivate the change.
Dominant language
Rust
Stars
2
Forks
2
Avg merge
12h 2m
Merged PRs (30d)
60

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from tableau/hyper-api-rust

All issues in tableau/hyper-api-rust

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.