Client-mode log directory is created under the umask, unlike the daemon's state directory
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Idoneità per principianti
- 78/100
Direzione di ricerca
Start with daemon::state_perms::ensure_owner_only_dir, then inspect engine::resolve_log_dir and the directory-creation call sites in hyperdb-mcp/src/main.rs and hyperdb-mcp/src/engine.rs. Check how Engine::new passes log_dir to hyperd and consider the adjacent ephemeral data directory. Done means client-mode log directories follow the daemon's owner-only policy, with the related data directory considered consistently.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Summary
The daemon's state directory and logs/ are created with an explicit owner-only mode
(daemon::state_perms, added in #295). The client/local-mode log directory is not: both
call sites use a plain std::fs::create_dir_all, so it takes the process umask — commonly
0755.
That directory holds the same class of file. In local mode Engine::new passes it to hyperd
as the engine's own log_dir, so hyperd writes its diagnostic logs there, and those records
name the endpoint just as the daemon's logs/ do. Restricting the daemon's state directory
while leaving the client's log directory at the umask is an inconsistency rather than a
deliberate difference.
Where
engine::resolve_log_dir(hyperdb-mcp/src/engine.rs) returns either the persistent file's
parent, orstd::env::temp_dir().join(format!("hyperdb-mcp-{pid}"))when the session is
ephemeral.- Both call sites create it with a plain
create_dir_all:hyperdb-mcp/src/main.rs(client-modetracingsetup, writeshyperdb-mcp.log)hyperdb-mcp/src/engine.rs(Engine::new)
Engine::newthen setsparams.set("log_dir", …)for the localHyperProcess, sohyperd
rotates its own logs into the same directory.- The adjacent ephemeral data directory (
hyperdb-mcp-<pid>-<seq>, holding the session's
.hyperfiles) is created the same way and is worth considering in the same pass.
Why it varies by platform
The ephemeral case is the one that matters, and how much depends on the platform:
- Linux —
temp_dir()is/tmp, which is shared and world-traversable, and the directory
name is just the pid. This is the case worth fixing. - macOS —
temp_dir()is a per-user/var/folders/…directory that is already0700, so
the parent covers it. - Windows — the per-user temp directory sits inside the user profile and inherits its ACL.
Suggested fix
Reuse daemon::state_perms::ensure_owner_only_dir at both call sites instead of
create_dir_all. It already creates at 0700, tightens a pre-existing directory, sweeps the
regular files inside it, and warns rather than failing when the filesystem has no modes to set
— the same policy the daemon paths use, which is what makes this a consistency fix rather than
a new one. Consider the ephemeral data directory too.
Notes
- Ordinary file-permission hygiene, not an urgent defect: on macOS and Windows the enclosing
directory already restricts access, and on Linux it affects a local developer tool's own
diagnostic output. - Deliberately out of scope for #295, which is about the daemon's state directory.
- Whether the client's own
hyperdb-mcp.logrecords the endpoint was not established —
notracingcall inengine.rs,server.rsormain.rsemits it as a field, though the
endpoint does appear in the text of a connect-failure message. Thehyperdlogs in the same
directory are the clear case, and they are enough to motivate the change.
- Lingua principale
- Rust
- Stelle
- 2
- Fork
- 2
- Merge medio
- 12h 2m
- PR unite (30g)
- 60
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di tableau/hyper-api-rust
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
tableau/hyper-api-rust#294 ·
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 35/100
tableau/hyper-api-rust#311 ·
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 45/100
tableau/hyper-api-rust#305 ·
-
Windows Named Pipe: verify DACL denies other users, and measure read-path perf for MCP workloads Aperta
Difficoltà 4/5 3-5 giorni Idoneità per principianti 38/100
tableau/hyper-api-rust#302 ·
-
Difficoltà 3/5 1-2 giorni Idoneità per principianti 72/100
tableau/hyper-api-rust#300 ·
Tutte le issue di tableau/hyper-api-rust
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
-
bug core
Difficoltà 2/5 1-3 ore Idoneità per principianti 86/100
-
JIT-compiled number -> Decimal conversion silently overflows instead of raising DECIMAL_OVERFLOW Apertafuzz
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
ClickHouse/ClickHouse#122114 ·
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 92/100
linebender/vello_svg#90 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100