A peer route test compares snapshots that include serverNow

Open Beginner friendly
  • Is something wrong?
#631 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
84/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Active
Tech stack
rust
Domain
testing

Research direction

Read tests/web/peer_routes.rs around line 195 and inspect how the snapshots from the two f.get calls are compared. Adjust the comparison to ignore serverNow, then run the peer route test to confirm the 404 request still leaves the relevant state unchanged.

Written by the indexing model from the issue text.

Description

peer::routes::a_session_action_with_extra_path_segments_is_not_found_and_changes_nothing (tests/web/peer_routes.rs:195) takes before = f.get(&path, 0), sends the 404 request, and asserts the second f.get equals before. The two snapshots differ only in serverNow, so a one-second tick between the reads fails the lane: seen on #630's gates (rust) (1794155450 against 1794155449) while #629 and #628 passed from the same minute. Compare the snapshots without serverNow. A test that reads the clock twice is the cause, not the dependency bump in #630.

Dominant language
Rust
Stars
223
Forks
148
Avg merge
1d 4h
Merged PRs (30d)
223

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sysprog21/codetrial

All issues in sysprog21/codetrial

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.