Guest photos missing for guests without GitHub — add X/Twitter photo fallback
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- javascript
Research direction
Start with the guest query in src/routes/(site)/guests/+page.server.ts, then inspect the image source logic in src/routes/(site)/guests/+page.svelte. Add the Twitter field to the selected guest data and use the stated Twitter fallback when GitHub is unavailable. Verify that guests with neither handle receive a generic placeholder and that the listed guests no longer show broken images.
Written by the indexing model from the issue text.
Description
The guests page sources all photos from https://github.com/{guest.github}.png. Guests without a GitHub handle get a broken/default image.
12 guests currently missing photos
| Guest | Twitter fallback available |
|---|---|
| Dr. Courtney Tolinski | ✅ drtolinski |
| Varun Mohan | ✅ _mohansolo |
| Taylor Desseyn | ✅ tdesseyn |
| Topher Martini | ✅ tophermartini |
| Hans Skillrud | ✅ DeepSpaceHans |
| Donata Skillrud | ✅ DonataSkillrud |
| Syed Balkhi | ✅ syedbalkhi |
| Tim Leland | ✅ TimLeland |
| Connor Finlayson | ✅ FinlaysonConnor |
| Harry Dry | ✅ harrydry |
| Loïc Houssier | ❌ no twitter either |
| Anna Poblets | ❌ no twitter either |
Proposed fix
Fall back to https://unavatar.io/twitter/{guest.twitter} when guest.github is null. Loïc Houssier and Anna Poblets would still need a generic placeholder.
Two small changes needed:
- Add
twitterto the guest select insrc/routes/(site)/guests/+page.server.ts - Update the
<img src>logic insrc/routes/(site)/guests/+page.svelteto use the fallback
- Dominant language
- Svelte
- Stars
- 1.2k
- Forks
- 515
- Avg merge
- 23h
- Merged PRs (30d)
- 13
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from syntaxfm/website
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Mark affiliate links Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 3/5 1-2 days Newbie friendliness 58/100
All issues in syntaxfm/website
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
gitbutlerapp/gitbutler#15998 · 1 comment ·
-
t/bug
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
task
Difficulty 2/5 1-3 hours Newbie friendliness 86/100