ShareWindow not shown when clicking Share in the player outside of show pages

Open Beginner friendly
#2,166 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
frontend

Research direction

Start with Player.svelte and src/routes/(site)/show/[show_number]/[slug]/+layout.svelte; trace the episode_share_status event and where ShareWindow is mounted. Check the site-wide layout for the appropriate shared location, then verify that clicking Share opens the modal from the homepage and a show page.

Written by the indexing model from the issue text.

Description

The share button in the audio player (Player.svelte) triggers episode_share_status, but the ShareWindow component that listens to that state is only mounted inside src/routes/(site)/show/[show_number]/[slug]/+layout.svelte.

As a result, clicking the share button in the player on the homepage (or any page that isn't a show page) does nothing — the modal never appears.

Expected behavior:
The share modal opens regardless of which page you're on.

Suggested fix:
Move ShareWindow into the site-wide layout so it's available on all pages where the player can be active.

Dominant language
Svelte
Stars
1.2k
Forks
515
Avg merge
23h
Merged PRs (30d)
13

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from syntaxfm/website

All issues in syntaxfm/website

Similar issues

More Web Dev issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.