[BridgeJS] Support union types
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Feature
- Clarity
- Needs clarification
- Activity status
- Quiet
- Tech stack
- javascript, swift, typescript
- Domain
- api
Research direction
No file or test is named. Start by locating the existing rawvalue support referenced in the issue and reviewing how the shown TypeScript unions map to Swift; clarify how runtime changes between variants should be represented. Done means the Example union and example() signature interoperate correctly, including dynamic changes between Foo and Bar.
Written by the indexing model from the issue text.
Description
Union types (other than rawvalue which are already done) should be supported. The best way to do this is unclear to me so this issue functions as a discussion point.
Example:
export type Foo = { foo: string }
export type Bar = { bar: string }
export type Example = Foo | Bar
export function example(): Example
Could maybe generate:
@JSClass struct Foo {
@JSGetter var foo: String
@JSSetter func setFoo(_ value: String) throws(JSException)
}
@JSClass struct Bar {
@JSGetter var bar: String
@JSSetter func setBar(_ value: String) throws(JSException)
}
@JSClass enum Example {
case foo(Foo)
case bar(Bar)
}
@JSFunction func example() throws(JSException) -> Example
Note that ts unions can change dynamically eg if I set foo to null and bar to a string, the type changes from Foo to Bar, so idk if that works with an enum like this in Swift.
- Dominant language
- Swift
- Stars
- 986
- Forks
- 76
- Avg merge
- 21h 11m
- Merged PRs (30d)
- 4
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from swiftwasm/JavaScriptKit
-
Difficulty 3/5 1-2 days Newbie friendliness 55/100
swiftwasm/JavaScriptKit#793 ·
-
swiftwasm/JavaScriptKit#785 · 1 assignee ·
-
[SwiftBuild] Preserve duplicate archive members when SwiftBuild expands static archives for linking Open
Difficulty 4/5 3-5 days Newbie friendliness 48/100
swiftwasm/JavaScriptKit#781 · 3 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
swiftwasm/JavaScriptKit#773 ·
-
swiftwasm/JavaScriptKit#767 · 1 assignee ·
All issues in swiftwasm/JavaScriptKit
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
manaflow-ai/cmux#13763 ·
-
type: feature request
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
googleapis/google-cloud-swift#1036 · 1 comment ·
-
Difficulty 1/5 Under an hour Newbie friendliness 78/100
wultra/mtoken-sdk-ios#253 ·
-
area:dictation documentation P2
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
uttrflow/uttrflow-swift#1180 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100