The linux Docker tests run as root

Open Beginner friendly
  • Is something wrong?
#352 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
67/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
docker, github-actions, swift
Domain
ci-cd, devops

Research direction

Read the Docker workflow and the referenced toolchain_matrix.yml line 30 to see how the Linux tests are launched. Check how the workflow sets the user inside its Docker container, then run the Linux Foundation tests and confirm they no longer run as root and the two reported failures are addressed.

Written by the indexing model from the issue text.

Description

We tried running the linux Foundation tests in this repo's Docker workflow and found that two tests are failing because they're run as root, which we had to work around, swiftlang/swift-corelibs-foundation#5659. This is not a good idea, both because most code won't run this way and because we're then testing a different scenario.

Apparently this is a known issue, @rnro, shouldn't we fix this?

Dominant language
Swift
Stars
115
Forks
60
Avg merge
1d 15h
Merged PRs (30d)
21

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from swiftlang/github-workflows

All issues in swiftlang/github-workflows

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.