HTTP/2 stream stays half-closed after an early response with status >= 300
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- swift
- Domain
- backend, networking
Research direction
Start with HTTP2ClientRequestHandler.runSuccessfulFinalAction and the state machine path described in the issue; compare how .close is handled for an early response while the request body is incomplete. Run swift test --filter 'HTTP2ClientRequestHandlerTests/testStreamIs' using the added tests in Tests/AsyncHTTPClientTests/HTTP2ClientRequestHandlerTests.swift. Done means the client sends RST_STREAM(CANCEL), the stream is released, and shutdown() completes.
Written by the indexing model from the issue text.
Description
AsyncHTTPClient commit hash: 017115279d09dbfd262a6c678e96d31c90b3b2aa (main).
Context
After an early complete response with status >= 300 (RFC 9113, section 8.1), the client sends neither END_STREAM nor RST_STREAM. The stream stays half-closed (remote), and the connection counts it as open. HTTPClient.shutdown() does not complete until the connection closes. Status < 300 is a different case: #922.
Example: apple/containerization sends each blob PUT without credentials first, and the registry answers 401 during the upload.
Cause:
- The request body is not complete.
HTTPRequestStateMachinereturns.forwardResponseEnd(.close, ...). - Since #657,
HTTP2ClientRequestHandler.runSuccessfulFinalActionignores.close, because "an h2 stream is closed after every request anyway". This is not true here. The request body stream is paused, and the.finishedstate machine rejects more body parts and the request end. HTTP2IdleHandlergets noStreamClosedEventfor this stream.- At
shutdown(), the stream getsHTTPConnectionEvent.shutdownRequested. The request is finished, sorequestCancelled()returns.wait.
Steps to reproduce
The repro sends one 64 MiB PUT without credentials to registry-1.docker.io over HTTP/2. The registry answers 401 during the upload.
git clone https://github.com/beshkenadze/async-http-client-early-response-leak
cd async-http-client-early-response-leak
AHC_REVISION=0171152 ./run.sh # AHC main
The README has the commands for 1.36.2, a lazy body and --wait 660, the output fields and the requirements.
The tests use only in-memory channels. git and SwiftPM need network access. The commands add only the fix branch's new tests to main:
git clone https://github.com/swift-server/async-http-client.git
cd async-http-client
git checkout 017115279d09dbfd262a6c678e96d31c90b3b2aa
git fetch https://github.com/beshkenadze/async-http-client.git fix/h2-reset-stream-after-early-response
git checkout FETCH_HEAD -- Tests/AsyncHTTPClientTests/HTTP2ClientRequestHandlerTests.swift
swift test --filter 'HTTP2ClientRequestHandlerTests/testStreamIs'
Expected result
The client sends RST_STREAM(CANCEL). The connection releases the stream, and shutdown() completes.
Actual result
| Run | openH2Streams |
shutdown() |
|---|---|---|
main and 1.36.2, eager and lazy body, 2 runs each |
1, in 8 of 8 runs | Does not complete in 10 s, in 8 of 8 runs. |
1.36.2, eager body, --wait 660, 1 run |
The stream and the connection closed together 61 s after the start of the run. | Completed at once after the 660 s wait. |
The fix for #939 does not change these results in 4 runs. The raw data names that build local@afcf468. Its Sources/ tree (6b69592) is the same as in beshkenadze:fix/early-response-request-body-stream.
| Test | Result |
|---|---|
testStreamIsClosedIfErrorResponseEndsBeforeRequestBodyIsSent |
Fails. After an early 401, the stream channel is still active (XCTAssertFalse failed). |
testStreamIsResetIfErrorResponseEndsBeforeRequestBodyIsSent |
Fails. The client sends no RST_STREAM: XCTAssertEqual failed: ("[]") is not equal to ("[HTTP2ErrorCode<0x8 Cancel>]") |
| The other 2 of the 4 tests | Pass. |
Raw data:
Environment
swift-nio-http2 1.46.0, macOS 27.0.1 (26A434).
$ swift --version
swift-driver version: 1.168.6 Apple Swift version 6.4 (swiftlang-6.4.0.34.1 clang-2100.3.34.1)
Target: arm64-apple-macosx27.0.0
$ uname -srvm
Darwin 27.0.0 Darwin Kernel Version 27.0.0: Tue Aug 11 21:22:49 PDT 2026; root:xnu-13432.1.9~1/RELEASE_ARM64_T6000 arm64
- Dominant language
- Swift
- Stars
- 1.1k
- Forks
- 159
- Avg merge
- 18h 43m
- Merged PRs (30d)
- 2
Getting set up
- No Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from swift-server/async-http-client
-
Difficulty 2/5 1-3 hours Newbie friendliness 73/100
swift-server/async-http-client#950 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
swift-server/async-http-client#946 · 2 comments ·
-
RequestBag keeps the request body after an early response with status >= 300Possibly taken @beshkenadze claimed this 28 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 68/100
-
Transaction keeps the request body after an early response with status >= 300Possibly taken @beshkenadze claimed this 28 days ago. Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
Difficulty 4/5 3-5 days Newbie friendliness 22/100
All issues in swift-server/async-http-client
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
Ranchero-Software/NetNewsWire#5572 ·
Maintainers usually reply within 11 days
-
api beginner story
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
NCSU-App-Development-Club/ios_fall_26#86 ·
Maintainers usually reply within 4 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
yetanotherbrowser/yab#1008 ·
Maintainers usually reply within 2 days
-
Difficulty 1/5 1-3 hours Newbie friendliness 90/100