Reject fractional maxResults in vector list operations
Maintainers usually reply within 1 day
Assessment
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- postgresql, typescript
Research direction
Read the /ListVectorBuckets and /ListIndexes request schemas and the route-level regression test described in the issue. Change both maxResults schemas from number to integer, then verify both routes reject 1.5 before invoking the vector store. An open linked pull request already addresses this issue.
Written by the indexing model from the issue text.
Description
Bug
The /ListVectorBuckets and /ListIndexes request schemas define maxResults as a JSON number. The validator therefore accepts fractional values such as 1.5, even though the S3 Vectors API defines this field as an integer in the range 1–500. The fractional page size is forwarded through the vector store and can fail when used for database pagination.
Expected behavior
Both operations should reject a fractional maxResults value as an invalid request before invoking the vector store.
Evidence
A direct route-level regression test sends maxResults: 1.5 to both endpoints. At current master, both requests pass validation and invoke the list handler. AWS documents maxResults as an integer for ListVectorBuckets and ListIndexes.
Scope
Change both request schemas from number to integer and retain regression coverage for both routes.
- Dominant language
- TypeScript
- Stars
- 1.3k
- Forks
- 314
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 90
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from supabase/storage
-
S3 HEAD/GET overwrite case-insensitive user metadata collisionsPossibly taken @ferhatelmas claimed this 16 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
supabase/storage#1461 · 1 assignee ·
Maintainers usually reply within 1 day
-
The sample application in storage article points to wrong URLMay be free again @prasadf18 claimed this 196 days ago, and no pull request is open. Opendocumentation
Difficulty 1/5 Under an hour Newbie friendliness 62/100
supabase/storage#557 · 1 comment ·
Maintainers usually reply within 1 day
-
Count S3 Vector key length by Unicode characterPossibly taken @hsusul claimed this 3 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
Maintainers usually reply within 1 day
-
S3 PutObject ignores Content-MD5 integrity checksPossibly taken @ferhatelmas claimed this 3 days ago. Open
Difficulty 3/5 1-2 days Newbie friendliness 70/100
supabase/storage#1561 · 1 assignee ·
Maintainers usually reply within 1 day
-
S3 DeleteObjects omits delete-marker metadata from successful versioned deletesPossibly taken @hsusul claimed this 5 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
Maintainers usually reply within 1 day
All issues in supabase/storage
Similar issues
-
[Bug]: REST API URL starting with "http" but no scheme (e.g. httpbin.org/get) is not given an http:// prefixPossibly taken @ItsDeadlyProgrammer claimed this today. Open
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
appsmithorg/appsmith#42471 · 1 comment ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ehmpathy/rhachet-roles-bhrain#705 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Status: Triage
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
mermaid-js/mermaid#8546 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
braintrustdata/braintrust-sdk-javascript#2659 ·
Maintainers usually reply within 1 day