`tx new liquidity-pool-deposit`/`-withdraw` reject the hex pool ID supported on other commands
Maintainers usually reply within 2 days
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 75/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- rust
- Domain
- blockchain, cli
Research direction
Start at the liquidity-pool-deposit and liquidity-pool-withdraw command entry points and compare their pool-ID parsing with revoke-sponsorship, which already accepts 64-character hex IDs. Verify both commands accept the Horizon-provided hex form while retaining support for the L… strkey form, then run the relevant CLI tests or build-only commands.
Written by the indexing model from the issue text.
Description
What version are you using?
stellar-cli 28.1.0 (d0b26d9, built from main).
What did you do?
I took a liquidity pool ID from Horizon and used it to build a deposit and a withdrawal:
curl -s 'https://horizon-testnet.stellar.org/liquidity_pools?limit=1' | jq -r '._embedded.records[0].id'
# 001041ac1d61419a62e0c0152e59f13aff7f8f65c2f04c1371ebbc662b31f4ab
stellar tx new liquidity-pool-deposit --source alice --network testnet --build-only \
--liquidity-pool-id 001041ac1d61419a62e0c0152e59f13aff7f8f65c2f04c1371ebbc662b31f4ab \
--max-amount-a 1 --max-amount-b 1 --min-price 1:1 --max-price 1:1
stellar tx new liquidity-pool-withdraw --source alice --network testnet --build-only \
--liquidity-pool-id 001041ac1d61419a62e0c0152e59f13aff7f8f65c2f04c1371ebbc662b31f4ab \
--amount 1 --min-amount-a 0 --min-amount-b 0
What did you expect to see?
The pool ID accepted as Horizon gives it. stellar tx new revoke-sponsorship --help lists 64-character hex pool IDs as accepted for its --liquidity-pool-id.
What did you see instead?
Both commands fail:
❌ error: invalid pool ID format: 001041ac1d61419a62e0c0152e59f13aff7f8f65c2f04c1371ebbc662b31f4ab
They only work after converting the ID to its L… strkey form first (stellar strkey encode '{"liquidity_pool":"001041…"}').
- Dominant language
- Rust
- Stars
- 123
- Forks
- 147
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 39
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from stellar/stellar-cli
-
Difficulty 1/5 1-3 hours Newbie friendliness 85/100
stellar/stellar-cli#2781 ·
Maintainers usually reply within 2 days
-
Display the full authorization tree before signing auth entriesPossibly taken @DeadZen claimed this 2 days ago. Open
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
stellar/stellar-cli#2779 ·
Maintainers usually reply within 2 days
-
`tx update sequence-number next` fails when the transaction source is a muxed accountPossibly taken @neimasilk-arch claimed this 1 day ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
stellar/stellar-cli#2774 ·
Maintainers usually reply within 2 days
-
`tx edit` fails on transaction XDR that is wrapped across multiple linesPossibly taken @neimasilk-arch claimed this 1 day ago. Openbug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
stellar/stellar-cli#2773 ·
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
stellar/stellar-cli#2753 ·
Maintainers usually reply within 2 days
All issues in stellar/stellar-cli
Similar issues
-
[Misdetection] `text/tab-separated-values` file misdetected as `text/tsv`Possibly taken @bact claimed this today. Openmisdetection needs triage
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 1 day
-
C-bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 2 days
-
vxc prints a debug line '[flat-codegen] emitted module via the flat path' on every compilePossibly taken @YodHeVauHe claimed this today. Opendevex good first issue
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
Maintainers usually reply within 3 days
-
Unused dependenciesOpen
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day