Action waits for RPC to be healthy, but not Horizon and Friendbot
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- docker, github-actions, shell
- Domain
- ci-cd, devops, infrastructure
Research direction
Start by reviewing the related #683 issue and the health-check logic in action.yml. Verify how readiness is currently determined for RPC, Horizon, and Friendbot, then run the GitHub Action and confirm it waits until the required services are healthy before account funding requests proceed.
Written by the indexing model from the issue text.
Description
The GitHub Action in the action.yml file waits for the container to be healthy, but does so by testing the RPC endpoint. The RPC is faster at getting setup than Horizon and subsequently Friendbot that uses Horizon. So when the RPC is healthy, if an account funding is sent immediately, Friendbot will fail to handle the request.
The health check should ensure that all the services, or the last service to start up (Friendbot) are healthy.
To do this, it would probably be helpful to first do this:
- #683
cc @stellar/devx
- Dominant language
- Shell
- Stars
- 224
- Forks
- 237
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 7
Getting set up
- Ships a Dockerfile or Docker Compose file
- No pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from stellar/quickstart
-
DockerHub README workflow fails with 403 ForbiddenPossibly taken @leighmcculloch claimed this 5 days ago. Openbug
stellar/quickstart#988 · 1 comment · 1 assignee ·
-
Difficulty 4/5 3-5 days Newbie friendliness 48/100
stellar/quickstart#932 · 18 comments · 2 reactions ·
-
Difficulty 4/5 3-5 days Newbie friendliness 58/100
stellar/quickstart#923 · 2 comments ·
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
stellar/quickstart#911 · 2 comments ·
-
feature request
Difficulty 5/5 Over a week Newbie friendliness 35/100
stellar/quickstart#907 · 1 comment ·
All issues in stellar/quickstart
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
AppImage/appimage.github.io#9676 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
YunoHost-Apps/pixelfed_ynh#346 ·
-
documentation
Difficulty 1/5 Under an hour Newbie friendliness 90/100
Maintainers usually reply within 1 day
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
Maintainers usually reply within 2 days
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 90/100
ChrisTitusTech/dwm-titus#367 ·
Maintainers usually reply within 1 day