Remove plot.network()'s reliance on the internal representaion of 'network'?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 35/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- r
- Domain
- backend-api-design
Research direction
Start at R/plot.R around line 804 and inspect how plot.network uses $oel and $iel to identify isolates. Review the networkLite implementation and the existing is.isolate() or degree() entry points, then determine the generic and method boundaries needed across supported object types. Done means plotting no longer depends on those internal fields and supported network objects retain correct isolate handling.
Written by the indexing model from the issue text.
Description
Specifically,
https://github.com/statnet/network/blob/769972a6d377e608143d8a05a3df8d6bb3de56be/R/plot.R#L804
relies on $oel and $iel solely to determine which nodes are isolates.
This means, e.g., networkLite objects has to implement its own function.
Probably the most elegant fix for this is to move the is.isolate() or maybe even degree() to network and make them generics, then have sna implement methods for whatever types it supports.
@CarterButts , thoughts?
- Dominant language
- R
- Stars
- 20
- Forks
- 7
- PR merge metrics
- No merged PRs in 30d
Getting set up
This project ships no dev container, Dockerfile or contributing guide, so setting up is up to you: start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from statnet/network
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
-
Assigning a symmetric sociomatrix valued edges to an undriected network creates bidirectional edges.Openbug
Difficulty 3/5 1-2 days Newbie friendliness 45/100
-
Difficulty 3/5 1-2 days Newbie friendliness 38/100
Similar issues
-
bug priority: should
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
The-Strategy-Unit/nhp_outputs#477 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Open-Systems-Pharmacology/OSPSuite.ReportingEngine#1380 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Open-Systems-Pharmacology/OSPSuite.ParameterIdentification#335 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100