Remove migration code not needed anymore since 26.11

Open Beginner friendly
#1,331 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
kubernetes, rust
Domain
backend

Research direction

Start with crates/stackable-operator/src/commons/random_secret_creation.rs and inspect create_random_secret_if_not_exists, especially the immutable Secret branch and its TODO. Remove the migration-only behavior and related code for the 27.3 release; the issue also suggests logging a warning when an immutable Secret indicates the upgrade was skipped. Done when the obsolete migration path and TODO are removed, with the warning decision handled.

Written by the indexing model from the issue text.

Description

scheduled-for/27.3.0

create_random_secret_if_not_exists (crates/stackable-operator/src/commons/random_secret_creation.rs) migrates random Secrets that SDP up to 26.3.0 created as immutable (https://github.com/stackabletech/issues/843). It deletes the immutable Secret and then re-creates it as mutable from the copy in memory.

This code is not needed anymore for 26.11 and later but we forgot to remove it. In 27.3 this can be removed.

Scope:

  • Remove the immutable: Some(true) branch and whatever else is only there for that including the TODO comment
  • And/or: Add a log warning for an immutable secret saying that the upgrade seems to have been skipped.
Dominant language
Rust
Stars
170
Forks
20
Avg merge
1d 10h
Merged PRs (30d)
17

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stackabletech/operator-rs

All issues in stackabletech/operator-rs

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.