Migrate host code onto the consolidated @spudly/ui surface (pages/views; no widget or icon imports) — completes the #413 adoption

Open
  • Is something wrong?
#440 0 comments 0 reactions 0 assignees View on GitHub

Maintainers usually reply within 1 day

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Mostly clear
Activity status
Active
Tech stack
react, typescript
Domain
frontend

Research direction

Start with the disposition table in spudly/design-system#438 and audit this repo’s @spudly/ui imports across the 64 page files and 102 widget-import files. Apply the listed page/view replacements, icon-name data, and isLoading to loading renames; check docs/manual-tests.md for the signed-out preview and footer verification. Done means the audit shows only allowed specifiers and CI and the scoped manual checks pass; the issue requires an approved plan and is blocked on #438.

Written by the indexing model from the issue text.

Description

blocked enhancement priority-p1

Summary

Host-side migration onto the consolidated @spudly/ui surface delivered by spudly/design-system#438. This issue executes the remaining adoption scope of #413 once the DS coverage release lands — no back-and-forth: design-system#438's plan (Part 0) dispositions every @spudly/ui specifier in this repo before its PR opens.

Blocked by: spudly/design-system#438 (carries blocker; this issue carries blocked).

End state for this repo

  • Imports from @spudly/ui use only: pages, eciperayTheme, tokens (incl. tag colors), createTamaguiConfig.
  • @spudly/ui/pages specifiers move to the root (45 page names, 64 files — specifier change only).
  • Zero widget imports (~30 distinct today across 102 files: Text, Button, RatingForm, SectionCard, ScreenContainer, Alert, TextLink, Card, TextAction, the form fields, Dialog, Badge, Spinner, etc.). Each host-composed fragment is replaced by the DS page/view expression named in design-system#438's disposition table.
  • Zero icon imports: the @spudly/ui/icons subpath usage (2 files, 10 icons) is replaced by icon names passed as data to pages/frames.
  • DS-prop rename: isLoading → loading (15 files).
  • PublicPageFrame receives the footer data (incl. the Do Not Sell link) — this is the #425 fix path; when this migration lands and QA verifies the signed-out footer on the preview, #425 closes and the hold on release PR #423 clears.

Acceptance

  • The disposition-table audit from design-system#438, re-run against this repo on the new DS release, returns only allowed specifiers.
  • CI green; manual preview test pass per docs/manual-tests.md trigger scoping (signed-out/read-only sections; the footer verification for #425 included).

Notes

  • Plan gate applies: an implementation plan will be posted on this issue for Stephen's approval before work starts (expected to be a short plan referencing design-system#438's disposition table).
  • #413 stays open as the adoption tracker and closes when this issue's PR merges.
Dominant language
TypeScript
Stars
0
Forks
0
Avg merge
8h 56m
Merged PRs (30d)
200

Getting set up

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from spudly/eciperay

All issues in spudly/eciperay

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.