[2.0 rc.13 + next] Aborted document closes a live-hole channel twice
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 55/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- typescript
- Domain
- backend
Research direction
The issue does not name Solid source files; start by reading the server-side streaming and live-channel cleanup paths implicated by the reproduction. Run the standalone repro.test.ts from the linked reproduction setup with a Solid HEAD build, then compare normal completion with abort followed by producer completion. Done means aborting and later completing the producer does not throw, while normal cleanup still works.
Written by the indexing model from the issue text.
Description
Describe the bug
Abort followed by producer completion should clean up once. Instead an uncaught Controller is already closed TypeError escapes the document live channel.
Your Example Website or App
Steps to Reproduce the Bug or Issue
- Use the source below with the selected Solid build (complete setup is linked above).
import { createMemo } from "solid-js";
import { renderToStream } from "@solidjs/web";
import { frameTransformDirectResult } from "@solidjs/web/frames/server";
export function startDocument(values: () => AsyncIterable<number>) {
const Component = frameTransformDirectResult(
() => {
const value = createMemo(values);
return <b>{value()}</b>;
},
{ id: "minimal" },
);
const controller = new AbortController();
let html = "";
const stream = renderToStream(() => Component(), {
signal: controller.signal,
onError() {},
});
stream.pipe({
write: (chunk) => {
html += String(chunk);
},
end() {},
});
// After the first value, abort(), then finish the source.
// Source completion throws "Controller is already closed".
return { abort: () => controller.abort(), html: () => html };
}
- Requires server-side streaming. Pass an async generator that yields 1 and then waits. Once 1 has streamed, call the returned
abort(), then release the generator. The normal-completion control cleans up once.
Expected behavior
Expected: Abort and later producer completion clean up without an uncaught exception.
Actual: Producer completion throws TypeError: "Controller is already closed".
Platform
- Solid:
solid-js/@solidjs/webnext at3086f1b77cd7b0431d3a7f768c2984c335758633; comparison2.0.0-rc.13. Signals, compiler and diagnostics match the selected Solid build. - OS: macOS 26.6.2 (25G83); browser cases: system Google Chrome 155.0.8059.40. Server-only/type checks run in Bun 1.4.2.
- Builds/comparison: Development, production, and observe fail on HEAD and rc.13. Observe is the production runtime with optional instrumentation.
Additional context
Aborting one document should close its live channel once. Double close rejects with an invalid stream state during cleanup.
Related: #3768
Full automated reproduction
One-command setup, run and expected output.
Copy the standalone folder into a fresh Bun project. The visible source above is executed by these tests; the additional files supply the required HTTP, compilation, and browser setup.
bun init -y
bun add [email protected] @solidjs/[email protected] @solidjs/[email protected] @solidjs/[email protected] @solidjs/[email protected]
bun add -d playwright
bun run link-head.ts /absolute/path/to/built/solid
BUILD_MODE=development bun test ./repro.test.ts
The link command selects a built Solid HEAD checkout; omit it for rc.13. Repeat with BUILD_MODE=production for the production comparison. Browser tests use system Google Chrome.
- Dominant language
- TypeScript
- Stars
- 36.1k
- Forks
- 1.1k
- Avg merge
- 11h 27m
- Merged PRs (30d)
- 351
Getting set up
- No Dockerfile or Docker Compose file
- Has a pull request template
- Read the contributing guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from solidjs/solid
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 18/100
Maintainers usually reply within 1 day
-
Difficulty 3/5 Half a day Newbie friendliness 55/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 18/100
Maintainers usually reply within 1 day
-
Difficulty 4/5 3-5 days Newbie friendliness 22/100
Maintainers usually reply within 1 day
Similar issues
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
supadata-ai/mcp#27 ·
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
capricorn86/happy-dom#2485 ·
Maintainers usually reply within 2 days
-
优化导入 OCR 模型选择文件的按钮样式Open
Difficulty 2/5 1-3 hours Newbie friendliness 66/100
siyuan-note/siyuan#20430 · 1 comment ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Maintainers usually reply within 2 days
-
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Albert-Weasker/niubigeo#194 ·
Maintainers usually reply within 1 day