Make ssr settings less strict

Open
#64 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
42/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript, vite
Domain
build-system, tooling

Research direction

Start with src/index.ts around line 377, where the SSR option is currently required, and compare that condition with the proposed generate and hydratable settings. Trace how the Vite plugin options are applied during SSG and verify that selected chunks can use ssr: true without requiring external option mutation.

Written by the indexing model from the issue text.

Description

I need to prerender certain pages in ssg mode, so some chunks should be trasnformed with ssr: true option.
However, this condition: https://github.com/solidjs/vite-plugin-solid/blob/master/src/index.ts#L377 requires in my plugin change option explicitly:

function setSSRMode(enable: boolean) {
  if (enable) {
     options.solidPluginOptionsRef.ssr = true
     options.solidPluginOptionsRef.solid!.hydratable = false
  } else {
     options.solidPluginOptionsRef.ssr = _ssr
     options.solidPluginOptionsRef.solid.hydratable = _hydratable
  }
}

async function getEntryFragment(entry: NormalizedEntry) {
  setSSRMode(true)
  const ssrMod = await server.ssrLoadModule(entry.ssrEntry, { fixStacktrace: true })
  setSSRMode(false)
  if (ssrMod.render?.constructor !== Function) {
     throw new Error(`SSG entry ${entry.ssrEntry} should provide 'render' export`)
  }
  const fragment = await ssrMod.render()
  return fragment
}

I suggest something like:

const generate = options.ssr || isSsr ? 'ssr' : 'dom'
const hydratable = isSsr || options.ssr

solidOptions = {
  generate,
  hydratable
};
Dominant language
TypeScript
Stars
520
Forks
70
Avg merge
23h 35m
Merged PRs (30d)
39

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from solidjs/solid-vite-plugin

All issues in solidjs/solid-vite-plugin

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.