Disabling `dev` option does nothing

Open
#62 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
build-system

Research direction

Start with the linked StackBlitz reproduction, focusing on vite.config.ts and src/index.tsx. Check how the dev option is handled and verify the logged DEV object; done means setting dev to false loads Solid's production runtime without the development-only functions.

Written by the indexing model from the issue text.

Description

I imagine that putting { dev: false } should prevent vite from loading the development runtime of solid, and load production instead. This doesn't seem to be happening though.

Simple repro: (the DEV object logged to console shouldn't have those functions available)
https://stackblitz.com/edit/github-z6ct5t?file=src%2Findex.tsx,vite.config.ts

Dominant language
TypeScript
Stars
520
Forks
70
Avg merge
23h 35m
Merged PRs (30d)
39

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from solidjs/solid-vite-plugin

All issues in solidjs/solid-vite-plugin

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.